Repository navigation
ref(debugMeta): Change debugmeta full text search to be no case sensitive - #19969
Merged
priscilawebdev merged 2 commits intoJul 21, 2020
Merged
Conversation
priscilawebdev
force-pushed
the
ref/make-images-loaded-search-non-case-sensitive
branch
from
July 21, 2020 13:38
f9b7709 to
65498cd
Compare
dashed
approved these changes
Jul 21, 2020
markstory
approved these changes
Jul 21, 2020
jan-auer
approved these changes
Jul 21, 2020
| if (!filter || filter.length < MIN_FILTER_LEN) { | ||
| const searchTerm = filter.toLowerCase(); | ||
|
|
||
| if (!searchTerm || searchTerm.length < MIN_FILTER_LEN) { |
Member
There was a problem hiding this comment.
This condition is redundant now, given that the above can never be null or it will error. The filter should never be null, but it could be when scrollToImage is invoked in the frame with a null instruction address. Not sure if you want to protect against that.
Suggested change
| if (!searchTerm || searchTerm.length < MIN_FILTER_LEN) { | |
| if (searchTerm.length < MIN_FILTER_LEN) { |
Member
Author
There was a problem hiding this comment.
good catch...thanks!!
priscilawebdev
deleted the
ref/make-images-loaded-search-non-case-sensitive
branch
July 21, 2020 15:58
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
closes: https://app.asana.com/0/1158284503473033/1185353197838710