Skip to content

ref(debugMeta): Change debugmeta full text search to be no case sensitive - #19969

Merged
priscilawebdev merged 2 commits into
masterfrom
ref/make-images-loaded-search-non-case-sensitive
Jul 21, 2020
Merged

priscilawebdev merged 2 commits into
masterfrom
ref/make-images-loaded-search-non-case-sensitive

Conversation

@priscilawebdev

@priscilawebdev priscilawebdev commented Jul 21, 2020 •

Copy link
Copy Markdown
Member

@vercel
vercel Bot temporarily deployed to Preview July 21, 2020 13:36 Inactive
@vercel
vercel Bot temporarily deployed to Preview July 21, 2020 13:38 Inactive
@priscilawebdev
priscilawebdev force-pushed the ref/make-images-loaded-search-non-case-sensitive branch from f9b7709 to 65498cd Compare July 21, 2020 13:38
@priscilawebdev
priscilawebdev requested a review from a team July 21, 2020 13:40
@priscilawebdev
priscilawebdev requested a review from jan-auer July 21, 2020 13:41
if (!filter || filter.length < MIN_FILTER_LEN) {
const searchTerm = filter.toLowerCase();

if (!searchTerm || searchTerm.length < MIN_FILTER_LEN) {

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This condition is redundant now, given that the above can never be null or it will error. The filter should never be null, but it could be when scrollToImage is invoked in the frame with a null instruction address. Not sure if you want to protect against that.

Suggested change
if (!searchTerm || searchTerm.length < MIN_FILTER_LEN) {
if (searchTerm.length < MIN_FILTER_LEN) {

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

good catch...thanks!!

@priscilawebdev
priscilawebdev merged commit 6908a8f into master Jul 21, 2020
@priscilawebdev
priscilawebdev deleted the ref/make-images-loaded-search-non-case-sensitive branch July 21, 2020 15:58
@github-actions github-actions Bot locked and limited conversation to collaborators Dec 18, 2020

This branch was successfully deployed

1 active deployment
Preview — 6af8320d Deployed Jul 21, 2020 by vercel[bot]
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants