Skip to content

ref(pii): Remove datascrubbers-v2 feat flag - #19971

Merged
priscilawebdev merged 1 commit into
masterfrom
ref/remove-datascrubbers-v2-feat-flag
Jul 22, 2020
Merged

priscilawebdev merged 1 commit into
masterfrom
ref/remove-datascrubbers-v2-feat-flag

Conversation

@priscilawebdev

Copy link
Copy Markdown
Member

No description provided.

@priscilawebdev
priscilawebdev requested review from a team and untitaker July 21, 2020 14:15
Comment thread src/sentry/tasks/store.py
@@ -459,9 +459,7 @@ def _do_process_event(

# XXX(markus): When datascrubbing is finally "totally stable", we might want
# to drop the event if it crashes to avoid saving PII

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does this TODO need to stick around?

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is about the safe_execute which I'd like to keep for now

@priscilawebdev
priscilawebdev merged commit d35a425 into master Jul 22, 2020
@priscilawebdev
priscilawebdev deleted the ref/remove-datascrubbers-v2-feat-flag branch July 22, 2020 07:36
@github-actions github-actions Bot locked and limited conversation to collaborators Dec 18, 2020

This branch was successfully deployed

1 active deployment
Preview — 57c7a1d4 Deployed Jul 21, 2020 by vercel[bot]
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants