Repository navigation
ref(pii): Remove datascrubbers-v2 feat flag - #19971
Merged
Merged
Conversation
untitaker
approved these changes
Jul 21, 2020
priscilawebdev
force-pushed
the
ref/remove-datascrubbers-v2-feat-flag
branch
from
July 21, 2020 15:58
f96059f to
57c7a1d
Compare
markstory
approved these changes
Jul 21, 2020
| @@ -459,9 +459,7 @@ def _do_process_event( | |||
|
|
|||
| # XXX(markus): When datascrubbing is finally "totally stable", we might want | |||
| # to drop the event if it crashes to avoid saving PII | |||
Member
There was a problem hiding this comment.
Does this TODO need to stick around?
Member
There was a problem hiding this comment.
This is about the safe_execute which I'd like to keep for now
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.