Skip to content

ref(span): Update list of browser JS SDKs #21931

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Nov 11, 2020
Merged

ref(span): Update list of browser JS SDKs #21931

merged 1 commit into from
Nov 11, 2020

Conversation

dashed
Copy link
Member

@dashed dashed commented Nov 11, 2020 •
edited
Loading

Update list of browser JS SDKs to include:

Certain cosmetic changes for the span view are enabled based on the SDK that the event is sourced from.

For Vue (before this PR):

image

@dashed dashed requested review from HazAT, lobsterkatie and a team November 11, 2020 15:23
@dashed dashed self-assigned this Nov 11, 2020
lobsterkatie
lobsterkatie approved these changes Nov 11, 2020
View reviewed changes
Copy link
Member

@lobsterkatie lobsterkatie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dashed dashed merged commit 30ec56e into master Nov 11, 2020
@dashed dashed deleted the js-sdk-browser-events-span-view branch November 11, 2020 16:42
@github-actions github-actions bot locked and limited conversation to collaborators Dec 17, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@silent1mezzo silent1mezzo silent1mezzo approved these changes

@lobsterkatie lobsterkatie lobsterkatie approved these changes

@HazAT HazAT Awaiting requested review from HazAT

Assignees

@dashed dashed

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@dashed @silent1mezzo @lobsterkatie