Skip to content

feat(ui): Reword javascript session tooltips #23530

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Feb 5, 2021
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 10 additions & 8 deletions src/sentry/static/sentry/app/views/releases/utils/sessionTerm.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -27,8 +27,10 @@ export const sessionTerm = {
// This should never be used directly (except in tests)
export const commonTermsDescription = {
[SessionTerm.CRASHES]: t('Number of sessions with a crashed state'),
[SessionTerm.CRASH_FREE_USERS]: t('Number of unique users with non-crashed sessions'),
[SessionTerm.CRASH_FREE_SESSIONS]: t('Number of non-crashed sessions'),
[SessionTerm.CRASH_FREE_USERS]: t(
'Percentage of unique users with non-crashed sessions'
),
[SessionTerm.CRASH_FREE_SESSIONS]: t('Percentage of non-crashed sessions'),
[SessionTerm.STABILITY]: t(
'The percentage of crash free sessions and how it has changed since the last period.'
),
Expand All @@ -39,7 +41,7 @@ export const mobileTermsDescription = {
[SessionTerm.CRASHED]: t(
'The process was terminated due to an unhandled exception or a request to the server that ended with an error'
),
[SessionTerm.CRASH_FREE_SESSIONS]: t('Number of unique sessions that did not crash'),
[SessionTerm.CRASH_FREE_SESSIONS]: t('Percentage of non-crashed sessions'),
[SessionTerm.ABNORMAL]: t(
'An unknown session exit. Like due to loss of power or killed by the operating system'
),
Expand Down Expand Up @@ -112,15 +114,15 @@ function getTermDescriptions(platform: PlatformKey | null) {
return {
...commonTermsDescription,
[SessionTerm.CRASHED]: t(
"During the session an error with mechanism.handled===false occurred calling the 'onerror' on 'unhandledrejection' handler"
'During the session an unhandled global error/promise rejection occurred.'
),
[SessionTerm.ABNORMAL]: t('Non applicable for Javascript'),
[SessionTerm.HEALTHY]: t('No errors were captured during session life-time'),
[SessionTerm.ABNORMAL]: t('Non applicable for Javascript.'),
[SessionTerm.HEALTHY]: t('No errors were captured during session life-time.'),
[SessionTerm.ERRORED]: t(
'During the session at least one error occurred that did not bubble up to the global handler. The application loading process did not crash'
'During the session at least one handled error occurred.'
),
[SessionTerm.UNHANDLED]:
"An error was captured by the global 'onerror' or 'onunhandledrejection' handler",
"An error was captured by the global 'onerror' or 'onunhandledrejection' handler.",
};
case 'apple-ios':
case 'minidump':
Expand Down
20 changes: 10 additions & 10 deletions tests/js/spec/views/releases/utils/sessionTerm.spec.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -488,7 +488,7 @@ describe('Release Health Session Term', function () {
'node-express'
);
expect(crashedSessionTerm).toEqual(
"During the session an error with mechanism.handled===false occurred calling the 'onerror' on 'unhandledrejection' handler"
'During the session an unhandled global error/promise rejection occurred.'
);

// Crash Free Users
Expand All @@ -510,15 +510,15 @@ describe('Release Health Session Term', function () {
SessionTerm.ABNORMAL,
'node-express'
);
expect(abnormalSessionTerm).toEqual('Non applicable for Javascript');
expect(abnormalSessionTerm).toEqual('Non applicable for Javascript.');

// Healthy
const healthySessionTerm = getSessionTermDescription(
SessionTerm.HEALTHY,
'node-express'
);
expect(healthySessionTerm).toEqual(
'No errors were captured during session life-time'
'No errors were captured during session life-time.'
);

// Errored
Expand All @@ -527,7 +527,7 @@ describe('Release Health Session Term', function () {
'node-express'
);
expect(erroredSessionTerm).toEqual(
'During the session at least one error occurred that did not bubble up to the global handler. The application loading process did not crash'
'During the session at least one handled error occurred.'
);

// Unhandled
Expand All @@ -536,7 +536,7 @@ describe('Release Health Session Term', function () {
'node-express'
);
expect(unhandledSessionTerm).toEqual(
"An error was captured by the global 'onerror' or 'onunhandledrejection' handler"
"An error was captured by the global 'onerror' or 'onunhandledrejection' handler."
);
});

Expand All @@ -554,7 +554,7 @@ describe('Release Health Session Term', function () {
'javascript'
);
expect(crashedSessionTerm).toEqual(
"During the session an error with mechanism.handled===false occurred calling the 'onerror' on 'unhandledrejection' handler"
'During the session an unhandled global error/promise rejection occurred.'
);

// Crash Free Users
Expand All @@ -576,15 +576,15 @@ describe('Release Health Session Term', function () {
SessionTerm.ABNORMAL,
'javascript'
);
expect(abnormalSessionTerm).toEqual('Non applicable for Javascript');
expect(abnormalSessionTerm).toEqual('Non applicable for Javascript.');

// Healthy
const healthySessionTerm = getSessionTermDescription(
SessionTerm.HEALTHY,
'javascript'
);
expect(healthySessionTerm).toEqual(
'No errors were captured during session life-time'
'No errors were captured during session life-time.'
);

// Errored
Expand All @@ -593,7 +593,7 @@ describe('Release Health Session Term', function () {
'javascript'
);
expect(erroredSessionTerm).toEqual(
'During the session at least one error occurred that did not bubble up to the global handler. The application loading process did not crash'
'During the session at least one handled error occurred.'
);

// Unhandled
Expand All @@ -602,7 +602,7 @@ describe('Release Health Session Term', function () {
'javascript'
);
expect(unhandledSessionTerm).toEqual(
"An error was captured by the global 'onerror' or 'onunhandledrejection' handler"
"An error was captured by the global 'onerror' or 'onunhandledrejection' handler."
);
});

Expand Down