fix(dev): Do not export SENTRY_DSN in .envrc #35440
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We started exporting SENTRY_DSN back in #32524 in order to fix errors in lib.sh not being reported. Having this variable exported can cause a lot of errors from a developers' development to show up as dev env errors. Exporting inside of lib.sh does not persist in the developers' environment.
armenzg
added
the
Component: Developer Environment
armenzg
commented
Jun 7, 2022
| @@ -142,8 +143,6 @@ fi | |||
| if [ -n "${SENTRY_DEVENV_NO_REPORT+x}" ]; then | |||
| debug "No development environment errors will be reported (since you've defined SENTRY_DEVENV_NO_REPORT)." | |||
| else | |||
| # This is necessary for the bash-hook in lib.sh to work | |||
| export SENTRY_DSN="https://[email protected]/5723503" | |||
There was a problem hiding this comment.
When exporting via direnv, any Sentry error reporting in the code will pick up the reserved variable.
| @@ -16,13 +16,8 @@ if sys.version_info.major < 3: | |||
| try: | |||
| import sentry_sdk | |||
|
|
|||
| if os.environ.get("SENTRY_DSN"): | |||
| sentry_sdk.init(dsn=os.environ["SENTRY_DSN"]) | |||
There was a problem hiding this comment.
I guess this block was redundant since init would have loaded automatically from the reserved variable.
| @@ -28,10 +28,13 @@ configure-sentry-cli() { | |||
| # We can remove this after it's fixed | |||
| # https://github.com/getsentry/sentry-cli/pull/1059 | |||
| export SENTRY_CLI_NO_EXIT_TRAP=${SENTRY_CLI_NO_EXIT_TRAP-0} | |||
| if [ -n "${SENTRY_DSN+x}" ] && [ -z "${SENTRY_DEVENV_NO_REPORT+x}" ]; then | |||
| if [ -z "${SENTRY_DEVENV_NO_REPORT+x}" ]; then | |||
There was a problem hiding this comment.
Since we now don't export the variable.
| if ! require sentry-cli; then | ||
| curl -sL https://sentry.io/get-cli/ | SENTRY_CLI_VERSION=2.0.4 bash | ||
| fi | ||
| # This exported variable does not persist outside of the calling script, thus, not affecting other | ||
| # parts of the system | ||
| export SENTRY_DSN="https://[email protected]/5723503" |
There was a problem hiding this comment.
Once the script that calls configure-sentry-cli ends, the variable is lost and the potential impact contained.
|
@asottile-sentry @Zylphrex would you mind testing that direnv works for you with this PR? (since you two were affected on #33826) |
flub
approved these changes
Jun 8, 2022
antonpirker
pushed a commit
that referenced
this pull request
Jun 8, 2022
We started exporting SENTRY_DSN back in #32524 in order to fix errors in lib.sh not being reported. Having this variable exported can cause a lot of errors from a developers' development to show up as dev env errors. Exporting inside of lib.sh does not persist in the developers' environment.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We started exporting SENTRY_DSN back in #32524 in order to fix errors in lib.sh not being reported.
Having this variable exported can cause a lot of errors from a developers' development to show up as dev env errors.
Exporting inside of lib.sh does not persist in the developers' environment.