Skip to content

fix(suspect-resolutions): Tweak commit correlation logic and track total events #37891

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 7 commits into from
Aug 17, 2022

Conversation

komal-saini
Copy link
Contributor

Changes:

  • Filter releases by date_added instead of querying GroupRelease and using last_seen
  • Add 1h delay to get_suspect_resolutions task if the issue was resolved in a commit, PR, or release
  • Track candidate_issue_total_events and resolved_issue_total_events in suspect_resolution.evaluation event

@github-actions github-actions bot added the Scope: Backend Automatically applied to PRs that change backend components label Aug 16, 2022
@@ -40,19 +40,20 @@ def is_issue_commit_correlated(
return CommitCorrelatedResult(
not resolved_filechanges.files_changed.isdisjoint(candidate_filechanges.files_changed),
resolved_filechanges.release_ids,
resolved_filechanges.release_ids,
candidate_filechanges.release_ids,
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice ..

@komal-saini komal-saini merged commit 0419374 into master Aug 17, 2022
@komal-saini komal-saini deleted the komal/suspect-resolutions-improvements branch August 17, 2022 03:08
@github-actions github-actions bot locked and limited conversation to collaborators Sep 1, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Scope: Backend Automatically applied to PRs that change backend components
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants