Skip to content

feat(loader): Ensure default integrations are added & work for performance #46995

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 6, 2023

Conversation

mydea
Copy link
Member

@mydea mydea commented Apr 6, 2023

This re-implements parts of the reverted #46447.

This updates the loader script to:

The other part is #46994 - this kind-of depends on this as without this the integrations will not be added (as the sample rates are not set). However they are only indirectly linked and can be merged/deployed separately.

Verification steps

  • I verified both the min & and full loader script generated are ES5 compliant with es-check
  • Tried in a local test app with the min & full loader script, both without performance/replay, as well as with them.
  • I put the generated min. loader script into the JS SDK integration tests

@mydea mydea requested a review from AbhiPrasad April 6, 2023 07:57
@mydea mydea self-assigned this Apr 6, 2023
@github-actions github-actions bot added Scope: Frontend Automatically applied to PRs that change frontend components Scope: Backend Automatically applied to PRs that change backend components labels Apr 6, 2023
@github-actions
Copy link
Contributor

github-actions bot commented Apr 6, 2023

🚨 Warning: This pull request contains Frontend and Backend changes!

It's discouraged to make changes to Sentry's Frontend and Backend in a single pull request. The Frontend and Backend are not atomically deployed. If the changes are interdependent of each other, they must be separated into two pull requests and be made forward or backwards compatible, such that the Backend or Frontend can be safely deployed independently.

Have questions? Please ask in the #discuss-dev-infra channel.

@mydea mydea added this to the JavaScript SDK Dynamic Loader milestone Apr 6, 2023
@AbhiPrasad AbhiPrasad removed the Scope: Frontend Automatically applied to PRs that change frontend components label Apr 6, 2023
@mydea mydea force-pushed the fn/loader-script-fixes branch from 4152107 to b20b711 Compare April 6, 2023 09:22
@github-actions github-actions bot added the Scope: Frontend Automatically applied to PRs that change frontend components label Apr 6, 2023
Copy link
Member

@AbhiPrasad AbhiPrasad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nothing seems to break when I ran in a local app! Let's :shipit:

@mydea mydea merged commit fe14ec2 into master Apr 6, 2023
@mydea mydea deleted the fn/loader-script-fixes branch April 6, 2023 09:45
@github-actions github-actions bot locked and limited conversation to collaborators Apr 21, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Scope: Backend Automatically applied to PRs that change backend components Scope: Frontend Automatically applied to PRs that change frontend components
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants