ref(replays): Refactor breadcrumb accessors to be memoized and central in ReplayReader #48745
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…l in ReplayReader
github-actions
bot
added
the
Scope: Frontend
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Moving the breadcrumb accessors into ReplayReader.
There are a few spots that were asking for all the raw breadcrumbs, and would then filter them down depending on the view. Well, it turns out that we probably don't need to re-filter everything each time those different views are rendered; especially since some of those views are rendered at the same time (timeline, breadcrumbs, +main section).
So this centralizes the filters, and adds
memoize()There's some followups I'm thinking about now too:
ReplaySpanandReplayCrumbtypes in all places. Make them both have subtypes for the different payload flavors (network spans, error crumbs, nav crumbs, etc).getPrevReplayEventfromstatic/app/views/replays/detail/breadcrumbs/index.tsx, we can do that stuff in css instead!Related to #47991