ref(crons): Remove {next,last}_checkin from monitor model (state) #49132
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
Scope: Backend
|
This PR has a migration; here is the generated SQL for --
-- Custom state/database change combination
-- |
evanpurkhiser
force-pushed
the
evanpurkhiser/ref-crons-remove-next-last-checkin-from-monitor-model-state-
branch
from
41863c8 to
d35ff5f
Compare
markstory
approved these changes
May 15, 2023
|
Should be totally unused as well |
wedamija
approved these changes
May 15, 2023
|
Sneaky, some test were still using it |
evanpurkhiser
force-pushed
the
evanpurkhiser/ref-crons-remove-next-last-checkin-from-monitor-model-state-
branch
from
d35ff5f to
40e4df6
Compare
evanpurkhiser
force-pushed
the
evanpurkhiser/ref-crons-remove-next-last-checkin-from-monitor-model-state-
branch
from
40e4df6 to
aef3d4c
Compare
evanpurkhiser
force-pushed
the
evanpurkhiser/ref-crons-remove-next-last-checkin-from-monitor-model-state-
branch
from
aef3d4c to
8e30cec
Compare
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## master #49132 +/- ##
==========================================
- Coverage 80.97% 80.97% -0.01%
==========================================
Files 4819 4819
Lines 202040 202037 -3
Branches 11397 11397
==========================================
- Hits 163603 163598 -5
- Misses 38183 38185 +2
Partials 254 254
|
|
This PR has a migration; here is the generated SQL for --
-- Custom state/database change combination
-- |
evanpurkhiser
deleted the
evanpurkhiser/ref-crons-remove-next-last-checkin-from-monitor-model-state-
branch
evanpurkhiser
added a commit
that referenced
this pull request
May 16, 2023
evanpurkhiser
added a commit
that referenced
this pull request
May 16, 2023
Follow up to #49132 --------- Co-authored-by: getsantry[bot] <66042841+getsantry[bot]@users.noreply.github.com>
volokluev
pushed a commit
that referenced
this pull request
May 30, 2023
…9132) This column is now unused (as monitor environments track these)
volokluev
pushed a commit
that referenced
this pull request
May 30, 2023
Follow up to #49132 --------- Co-authored-by: getsantry[bot] <66042841+getsantry[bot]@users.noreply.github.com>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This column is now unused (as monitor environments track these)