Skip to content

feat(replay): Render an unstyled Replay Preview for Replay Issues #50538

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 2 commits into from

Conversation

ryan953
Copy link
Member

@ryan953 ryan953 commented Jun 7, 2023

The purpose of this PR is to implement some feature checks so we can work inside them.

When organizations:issue-details-replay-event is deployed & enabled you'll see an unstyled <ReplayPreview>:

SCR-20230607-oxci

With these initial checks in place i'm going to follow up with some refactors to the ReplayPreview, and style the thing for this position in the page.

Can test by opening the new issue type.
Example: https://sentry.dev.getsentry.net:7999/issues/4229046598/events/bdbfa6060685497187ae716e5a3e196d/?project=11276&referrer=previous-event

Related to:

@github-actions github-actions bot added the Scope: Frontend Automatically applied to PRs that change frontend components label Jun 7, 2023
@ryan953 ryan953 requested review from billyvg, scttcper, mydea, cmanallen, eliashussary and a team and removed request for mydea June 7, 2023 23:34
@ryan953 ryan953 requested a review from a team as a code owner June 7, 2023 23:51
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm leaving most of these enabled, even though they might not work yet, so we can see them and fix them.

@billyvg
Copy link
Member

billyvg commented Jun 7, 2023

We are pulling back on dead click as a replay issue, so not sure how we want to go forward with this.

@ryan953
Copy link
Member Author

ryan953 commented Jun 7, 2023

We are pulling back on dead click as a replay issue, so not sure how we want to go forward with this.

kk. I'll let it marinate for a bit.

@cmanallen
Copy link
Member

Rage clicks might make the cut. But who knows. We'll see after we gather more data.

@ryan953 ryan953 marked this pull request as draft June 14, 2023 15:27
@github-actions
Copy link
Contributor

github-actions bot commented Jul 6, 2023

This pull request has gone three weeks without activity. In another week, I will close it.

But! If you comment or otherwise update it, I will reset the clock, and if you label it Status: Backlog or Status: In Progress, I will leave it alone ... forever!


"A weed is but an unloved flower." ― Ella Wheeler Wilcox 🥀

@ryan953 ryan953 closed this Jul 6, 2023
@github-actions github-actions bot locked and limited conversation to collaborators Jul 21, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Scope: Frontend Automatically applied to PRs that change frontend components
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants