Skip to content

ref(replay): Accept replay attachments in-order so we do not have to manually sort later #50901

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jun 16, 2023

Conversation

ryan953
Copy link
Member

@ryan953 ryan953 commented Jun 13, 2023

This is a followup from #50707

Fixes #50891

@ryan953 ryan953 requested review from a team as code owners June 13, 2023 23:38
@ryan953 ryan953 requested a review from billyvg June 13, 2023 23:38
@github-actions github-actions bot added the Scope: Frontend Automatically applied to PRs that change frontend components label Jun 13, 2023
Base automatically changed from ryan953/47991-hydrate-replay-frame-types to master June 16, 2023 17:25
@ryan953 ryan953 force-pushed the ryan953/50891-replay-attachments-in-order branch from 20e1037 to 0b03239 Compare June 16, 2023 17:37
@ryan953 ryan953 enabled auto-merge (squash) June 16, 2023 17:40
@ryan953 ryan953 merged commit e4abf10 into master Jun 16, 2023
@ryan953 ryan953 deleted the ryan953/50891-replay-attachments-in-order branch June 16, 2023 18:55
@github-actions github-actions bot locked and limited conversation to collaborators Jul 2, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Scope: Frontend Automatically applied to PRs that change frontend components
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Replay Details] Improve useReplayData so that it returns attachments in-order
2 participants