ref(replay): Convert Errors Tab to use *Frame types
#51559
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
Scope: Frontend
ryan953
force-pushed
the
ryan953/ref-replay-errors-uses-frames
branch
from
38dd44f to
927510f
Compare
ryan953
commented
Jun 28, 2023
| [crumb.timestamp, startTimestampMs] | ||
| ); | ||
| const hasOccurred = currentTime >= crumbTime; | ||
| const isBeforeHover = currentHoverTime === undefined || currentHoverTime >= crumbTime; |
There was a problem hiding this comment.
yay, simplify things with the new types and their extra fields.
ryan953
commented
Jun 28, 2023
| searchTerm: (item: ErrorFrame, searchTerm: string) => | ||
| [item.message, ...item.data.labels].some(str => | ||
| str.toLowerCase().includes(searchTerm) | ||
| ), |
There was a problem hiding this comment.
changed to remove the JSON.stringify business, instead look at message and labels on their own
ryan953
changed the title
*Frame types
billyvg
approved these changes
Jul 3, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Relates to #47991