-
-
Notifications
You must be signed in to change notification settings - Fork 4.4k
ref(replay): Refactor Replay Details>Console tab to use the new *Frames types #53660
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
@@ -144,18 +127,35 @@ const ConsoleLog = styled('div')<{ | |||
`; | |||
|
|||
const ICONS = { | |||
[BreadcrumbLevelType.ERROR]: <IconFire size="xs" />, | |||
[BreadcrumbLevelType.WARNING]: <IconWarning size="xs" />, | |||
[BreadcrumbLevelType.ERROR]: ( |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why did we change the error icon from "fire" to "close"?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
+1 curious about this too
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
{breadcrumbHasIssue(breadcrumb) ? ( | ||
<IssueLinkWrapper> | ||
<ViewIssueLink breadcrumb={breadcrumb} /> | ||
</IssueLinkWrapper> | ||
) : null} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do we no longer link to the issue now? I liked that link to differentiate the sentry error from console error.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This was here from when we showed issues inside the console. But this is dead code now that we've moved issues/errors into the Errors tab.
@@ -144,18 +127,35 @@ const ConsoleLog = styled('div')<{ | |||
`; | |||
|
|||
const ICONS = { | |||
[BreadcrumbLevelType.ERROR]: <IconFire size="xs" />, | |||
[BreadcrumbLevelType.WARNING]: <IconWarning size="xs" />, | |||
[BreadcrumbLevelType.ERROR]: ( |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
+1 curious about this too
Refactored to use the
*Frame
types.Also, we are now also rendering custom breadcrumbs in the console tab! see screen shot and
redux.action
rows.relates to #47991