ref(replay): Refactor Replay Details>Console tab to use the new *Frames types #53660
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
Scope: Frontend
| @@ -144,18 +127,35 @@ const ConsoleLog = styled('div')<{ | |||
| `; | |||
|
|
|||
| const ICONS = { | |||
| [BreadcrumbLevelType.ERROR]: <IconFire size="xs" />, | |||
| [BreadcrumbLevelType.WARNING]: <IconWarning size="xs" />, | |||
| [BreadcrumbLevelType.ERROR]: ( | |||
There was a problem hiding this comment.
Why did we change the error icon from "fire" to "close"?
There was a problem hiding this comment.
So i was thinking that Sentry Errors (in the timeline and bredcrumbs, etc) are using the Fire icon already. And these rows are not errors, so it should be different. Also chrome console uses the x and tringle things:
billyvg
reviewed
Jul 27, 2023
Comment on lines
-84
to
-88
| {breadcrumbHasIssue(breadcrumb) ? ( | ||
| <IssueLinkWrapper> | ||
| <ViewIssueLink breadcrumb={breadcrumb} /> | ||
| </IssueLinkWrapper> | ||
| ) : null} |
There was a problem hiding this comment.
Do we no longer link to the issue now? I liked that link to differentiate the sentry error from console error.
There was a problem hiding this comment.
This was here from when we showed issues inside the console. But this is dead code now that we've moved issues/errors into the Errors tab.
| @@ -144,18 +127,35 @@ const ConsoleLog = styled('div')<{ | |||
| `; | |||
|
|
|||
| const ICONS = { | |||
| [BreadcrumbLevelType.ERROR]: <IconFire size="xs" />, | |||
| [BreadcrumbLevelType.WARNING]: <IconWarning size="xs" />, | |||
| [BreadcrumbLevelType.ERROR]: ( | |||
billyvg
approved these changes
Jul 28, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refactored to use the
*Frametypes.Also, we are now also rendering custom breadcrumbs in the console tab! see screen shot and
redux.actionrows.relates to #47991