Skip to content

ref(replay): Cleanup dead replay code related to non-frame types and utils #54066

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Aug 2, 2023
Merged

ref(replay): Cleanup dead replay code related to non-frame types and utils #54066

merged 2 commits into from
Aug 2, 2023

Conversation

ryan953
Copy link
Member

@ryan953 ryan953 commented Aug 2, 2023 •
edited
Loading

The end of an era, all the replay frontend is using the *Frame types, no more Crumb

Fixes #47991

@ryan953 ryan953 requested a review from a team as a code owner August 2, 2023 21:44
@github-actions github-actions bot added the Scope: Frontend Automatically applied to PRs that change frontend components label Aug 2, 2023
@ryan953
Copy link
Member Author

ryan953 commented Aug 2, 2023

oppenheimer-1670924274

@ryan953 ryan953 enabled auto-merge (squash) August 2, 2023 22:01
@ryan953 ryan953 merged commit 7d212a1 into master Aug 2, 2023
@ryan953 ryan953 deleted the ryan953/ref-cleanup-replay-non-frame-code branch August 2, 2023 22:18
@github-actions github-actions bot locked and limited conversation to collaborators Aug 18, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@billyvg billyvg billyvg approved these changes

@michellewzhang michellewzhang Awaiting requested review from michellewzhang

Assignees
No one assigned
Labels
Scope: Frontend Automatically applied to PRs that change frontend components
Projects
None yet
Milestone
No milestone
2 participants
@ryan953 @billyvg