tag: fix bad tag change and flickering text #91927
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
Scope: Frontend
TkDodo
approved these changes
May 20, 2025
static/app/views/releases/list/releaseCard/releaseCardCommits.tsx
Outdated
Show resolved
Hide resolved
TkDodo
approved these changes
May 21, 2025
markstory
added a commit
that referenced
this pull request
May 27, 2025
We often test tasks by calling the functions directly. We should validate those call sites to ensure that they are not violating JSON encodable parameters. Refs #91927
markstory
added a commit
that referenced
this pull request
May 28, 2025
We often test tasks by calling the functions directly. We should validate those call sites to ensure that they are not violating JSON encodable parameters. Refs #91927
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes a bad tag change where the text became bolded (I must have modified the wrong tag and not noticed it)
Also removes a custom component for the tag pill (this must have been like this before), which makes this look better aligned and with a more appropriate font size
Before
After
Also fixed this awkward flickering caused by the tooltip on the avatar (first interaction is fixed state, second one is from prod)
CleanShot.2025-05-20.at.10.13.46.mp4