dx12: Implement buffer views #1987
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kvark
approved these changes
May 4, 2018
src/backend/dx12/src/device.rs
Outdated
| } | ||
| pso::Descriptor::TexelBuffer(_) => unimplemented!() | ||
| pso::Descriptor::UniformTexelBuffer(buffer_view) => { | ||
| src_views.push(buffer_view.handle_srv); |
Member
There was a problem hiding this comment.
given that the SRV here and UAV below can be NULL, can we at least error!() on it?
Member
|
bors r+ |
bors bot
added a commit
that referenced
this pull request
May 4, 2018
1987: dx12: Implement buffer views r=kvark a=msiglreith Untested so far, probably requires small changes to portability due to API breakage. Co-authored-by: msiglreith <[email protected]>
Member
|
Looks like Metal needs a few more corrections: |
Contributor
Build failed |
bors bot
added a commit
that referenced
this pull request
May 4, 2018
1985: mtl: Map more vertex formats r=kvark a=grovesNL Depends on gfx-rs/metal-rs#41 to be merged/published. Not sure what to do with `Int1010102Normalized` and `UInt1010102Normalized` because the byte ordering for alpha appears to differ from Vulkan, so I'm leaving them out for now. PR checklist: - [X] `make` succeeds (on *nix) - [X] `make reftests` succeeds - [X] tested examples with the following backends: Metal 1987: dx12: Implement buffer views r=kvark a=msiglreith Untested so far, probably requires small changes to portability due to API breakage. Co-authored-by: Joshua Groves <[email protected]> Co-authored-by: msiglreith <[email protected]>
Contributor
Build failed (retrying...) |
Contributor
Canceled |
Contributor
Author
|
bors r=kvark |
bors bot
added a commit
that referenced
this pull request
May 4, 2018
1987: dx12: Implement buffer views r=kvark a=msiglreith Untested so far, probably requires small changes to portability due to API breakage. Co-authored-by: msiglreith <[email protected]>
Contributor
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Untested so far, probably requires small changes to portability due to API breakage.