Skip to content

[dx12] update d3d12 to 0.3 and use explicit linking #3068

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 1, 2019

Conversation

kvark
Copy link
Member

@kvark kvark commented Nov 1, 2019

Fixes #3067 (not exactly matching the wording but addresses the real blocker)
Depends on gfx-rs/d3d12-rs#20 merged and published, doesn't need to be updated when that happens
PR checklist:

  • make succeeds (on *nix)
  • make reftests succeeds
  • tested examples with the following backends: d3d12
  • rustfmt run on changed code

Verified on a Windows 7 machine that we are gracefully failing to init DX12 now.

Copy link
Contributor

@msiglreith msiglreith left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Bors r+

bors bot added a commit that referenced this pull request Nov 1, 2019
3068: [dx12] update d3d12 to 0.3 and use explicit linking r=msiglreith a=kvark

Fixes #3067 (not exactly matching the wording but addresses the real blocker)
Depends on gfx-rs/d3d12-rs#20 merged and published, doesn't need to be updated when that happens
PR checklist:
- [ ] `make` succeeds (on *nix)
- [ ] `make reftests` succeeds
- [x] tested examples with the following backends: d3d12
- [ ] `rustfmt` run on changed code

Verified on a Windows 7 machine that we are gracefully failing to init DX12 now.

Co-authored-by: Dzmitry Malyshau <[email protected]>
@kvark
Copy link
Member Author

kvark commented Nov 1, 2019

bors retry

bors bot added a commit that referenced this pull request Nov 1, 2019
3068: [dx12] update d3d12 to 0.3 and use explicit linking r=msiglreith a=kvark

Fixes #3067 (not exactly matching the wording but addresses the real blocker)
Depends on gfx-rs/d3d12-rs#20 merged and published, doesn't need to be updated when that happens
PR checklist:
- [ ] `make` succeeds (on *nix)
- [ ] `make reftests` succeeds
- [x] tested examples with the following backends: d3d12
- [ ] `rustfmt` run on changed code

Verified on a Windows 7 machine that we are gracefully failing to init DX12 now.

Co-authored-by: Dzmitry Malyshau <[email protected]>
@bors
Copy link
Contributor

bors bot commented Nov 1, 2019

Build succeeded

@bors bors bot merged commit 1ddd20d into gfx-rs:master Nov 1, 2019
@kvark kvark deleted the dx12-load branch November 1, 2019 16:46
bors bot added a commit that referenced this pull request Nov 1, 2019
3069: [0.4/dx12] update d3d12 to 0.3 and use explicit linking r=msiglreith a=kvark

Sibling of #3068
Also depends on gfx-rs/d3d12-rs#20

Co-authored-by: Dzmitry Malyshau <[email protected]>
@kvark kvark mentioned this pull request Nov 4, 2019
4 tasks
bors bot added a commit that referenced this pull request Nov 4, 2019
3076: [0.4/dx11] explicit library loading r=kvark a=kvark

Supposedly fixes 32bit windows mingw CI: https://treeherder.mozilla.org/logviewer.html#/jobs?job_id=274334639&repo=try&lineNumber=88036
Similar to #3068 but for dx11

PR checklist:
- [ ] `make` succeeds (on *nix)
- [ ] `make reftests` succeeds
- [x] tested examples with the following backends: dx11
- [ ] `rustfmt` run on changed code


Co-authored-by: Dzmitry Malyshau <[email protected]>
bors bot added a commit that referenced this pull request Nov 4, 2019
3076: [0.4/dx11] explicit library loading r=kvark a=kvark

Supposedly fixes 32bit windows mingw CI: https://treeherder.mozilla.org/logviewer.html#/jobs?job_id=274334639&repo=try&lineNumber=88036
Similar to #3068 but for dx11

PR checklist:
- [ ] `make` succeeds (on *nix)
- [ ] `make reftests` succeeds
- [x] tested examples with the following backends: dx11
- [ ] `rustfmt` run on changed code


Co-authored-by: Dzmitry Malyshau <[email protected]>
bors bot added a commit that referenced this pull request Nov 4, 2019
3076: [0.4/dx11] explicit library loading r=kvark a=kvark

Supposedly fixes 32bit windows mingw CI: https://treeherder.mozilla.org/logviewer.html#/jobs?job_id=274334639&repo=try&lineNumber=88036
Similar to #3068 but for dx11

PR checklist:
- [ ] `make` succeeds (on *nix)
- [ ] `make reftests` succeeds
- [x] tested examples with the following backends: dx11
- [ ] `rustfmt` run on changed code


Co-authored-by: Dzmitry Malyshau <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Only use d3d12-rs to access DX12 functionality
2 participants