-
Notifications
You must be signed in to change notification settings - Fork 541
[dx12] update d3d12 to 0.3 and use explicit linking #3068
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
msiglreith
approved these changes
Nov 1, 2019
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Bors r+
bors bot
added a commit
that referenced
this pull request
Nov 1, 2019
3068: [dx12] update d3d12 to 0.3 and use explicit linking r=msiglreith a=kvark Fixes #3067 (not exactly matching the wording but addresses the real blocker) Depends on gfx-rs/d3d12-rs#20 merged and published, doesn't need to be updated when that happens PR checklist: - [ ] `make` succeeds (on *nix) - [ ] `make reftests` succeeds - [x] tested examples with the following backends: d3d12 - [ ] `rustfmt` run on changed code Verified on a Windows 7 machine that we are gracefully failing to init DX12 now. Co-authored-by: Dzmitry Malyshau <[email protected]>
bors retry |
bors bot
added a commit
that referenced
this pull request
Nov 1, 2019
3068: [dx12] update d3d12 to 0.3 and use explicit linking r=msiglreith a=kvark Fixes #3067 (not exactly matching the wording but addresses the real blocker) Depends on gfx-rs/d3d12-rs#20 merged and published, doesn't need to be updated when that happens PR checklist: - [ ] `make` succeeds (on *nix) - [ ] `make reftests` succeeds - [x] tested examples with the following backends: d3d12 - [ ] `rustfmt` run on changed code Verified on a Windows 7 machine that we are gracefully failing to init DX12 now. Co-authored-by: Dzmitry Malyshau <[email protected]>
Build succeeded |
bors bot
added a commit
that referenced
this pull request
Nov 1, 2019
3069: [0.4/dx12] update d3d12 to 0.3 and use explicit linking r=msiglreith a=kvark Sibling of #3068 Also depends on gfx-rs/d3d12-rs#20 Co-authored-by: Dzmitry Malyshau <[email protected]>
4 tasks
bors bot
added a commit
that referenced
this pull request
Nov 4, 2019
3076: [0.4/dx11] explicit library loading r=kvark a=kvark Supposedly fixes 32bit windows mingw CI: https://treeherder.mozilla.org/logviewer.html#/jobs?job_id=274334639&repo=try&lineNumber=88036 Similar to #3068 but for dx11 PR checklist: - [ ] `make` succeeds (on *nix) - [ ] `make reftests` succeeds - [x] tested examples with the following backends: dx11 - [ ] `rustfmt` run on changed code Co-authored-by: Dzmitry Malyshau <[email protected]>
bors bot
added a commit
that referenced
this pull request
Nov 4, 2019
3076: [0.4/dx11] explicit library loading r=kvark a=kvark Supposedly fixes 32bit windows mingw CI: https://treeherder.mozilla.org/logviewer.html#/jobs?job_id=274334639&repo=try&lineNumber=88036 Similar to #3068 but for dx11 PR checklist: - [ ] `make` succeeds (on *nix) - [ ] `make reftests` succeeds - [x] tested examples with the following backends: dx11 - [ ] `rustfmt` run on changed code Co-authored-by: Dzmitry Malyshau <[email protected]>
bors bot
added a commit
that referenced
this pull request
Nov 4, 2019
3076: [0.4/dx11] explicit library loading r=kvark a=kvark Supposedly fixes 32bit windows mingw CI: https://treeherder.mozilla.org/logviewer.html#/jobs?job_id=274334639&repo=try&lineNumber=88036 Similar to #3068 but for dx11 PR checklist: - [ ] `make` succeeds (on *nix) - [ ] `make reftests` succeeds - [x] tested examples with the following backends: dx11 - [ ] `rustfmt` run on changed code Co-authored-by: Dzmitry Malyshau <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #3067 (not exactly matching the wording but addresses the real blocker)
Depends on gfx-rs/d3d12-rs#20 merged and published, doesn't need to be updated when that happens
PR checklist:
make
succeeds (on *nix)make reftests
succeedsrustfmt
run on changed codeVerified on a Windows 7 machine that we are gracefully failing to init DX12 now.