-
Notifications
You must be signed in to change notification settings - Fork 134
Add 'wgpu_device_destroy_render_pipeline()' function #28
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add 'wgpu_device_destroy_render_pipeline()' function #28
Conversation
kvark
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you! Just one question
|
@kvark added a few more missing. I also renamed the added destroy functions to match what you previously did (I removed the "device" part of the name which isn't necessary). Let me know if you need anything else! |
kvark
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you! Just one concern here
kvark
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There is a bit of problem down the road - shared headers use destroy only on buffers and textures, and the semantics is different. We'll probably need to rename them to something else in wgpu-native.
But for now this is consistent with what we have.
|
Please squash and also run |
5ad43fd to
3cb6dd9
Compare
kvark
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you!
bors r+
|
Build failed: |
|
Bah, nightly is all broken: |
|
Filed as rust-lang/rust#72467 |
|
bors retry |
Hi,
Nothing fancy, this PR simply forward the call
wgpu_device_destroy_render_pipeline()to therender_pipeline_destroy()method inwgpu-core.