Skip to content

Conversation

@DavidPeicho
Copy link
Contributor

Hi,

Nothing fancy, this PR simply forward the call wgpu_device_destroy_render_pipeline() to the render_pipeline_destroy() method in wgpu-core.

Copy link
Member

@kvark kvark left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you! Just one question

@DavidPeicho
Copy link
Contributor Author

DavidPeicho commented May 20, 2020

@kvark added a few more missing. I also renamed the added destroy functions to match what you previously did (I removed the "device" part of the name which isn't necessary). Let me know if you need anything else!

Copy link
Member

@kvark kvark left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you! Just one concern here

Copy link
Member

@kvark kvark left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There is a bit of problem down the road - shared headers use destroy only on buffers and textures, and the semantics is different. We'll probably need to rename them to something else in wgpu-native.
But for now this is consistent with what we have.

@kvark
Copy link
Member

kvark commented May 21, 2020

Please squash and also run make so that the C header is updated.

@DavidPeicho DavidPeicho force-pushed the feature/destroy-render-pipeline branch from 5ad43fd to 3cb6dd9 Compare May 21, 2020 23:18
Copy link
Member

@kvark kvark left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!
bors r+

bors bot added a commit that referenced this pull request May 22, 2020
28: Add 'wgpu_device_destroy_render_pipeline()' function r=kvark a=DavidPeicho

Hi,

Nothing fancy, this PR simply forward the call `wgpu_device_destroy_render_pipeline()` to the `render_pipeline_destroy()` method in `wgpu-core`. 

Co-authored-by: David Peicho <david.peicho@gmail.com>
@bors
Copy link
Contributor

bors bot commented May 22, 2020

Build failed:

@kvark
Copy link
Member

kvark commented May 22, 2020

Bah, nightly is all broken:

thread 'rustc' panicked at 'index out of bounds: the len is 0 but the index is 0', src/librustc_mir_build/hair/pattern/_match.rs:1184:21
note: run with `RUST_BACKTRACE=1` environment variable to display a backtrace

error: internal compiler error: unexpected panic

note: the compiler unexpectedly panicked. this is a bug.

note: we would appreciate a bug report: https://github.com/rust-lang/rust/blob/master/CONTRIBUTING.md#bug-reports

note: rustc 1.45.0-nightly (9310e3bd4 2020-05-21) running on x86_64-apple-darwin

note: compiler flags: -C embed-bitcode=no -C debuginfo=2 --crate-type lib

note: some of the compiler flags provided by cargo are hidden

error: could not compile `gfx-backend-metal`.

@kvark
Copy link
Member

kvark commented May 22, 2020

Filed as rust-lang/rust#72467

@kvark
Copy link
Member

kvark commented Jun 2, 2020

bors retry

@bors
Copy link
Contributor

bors bot commented Jun 2, 2020

@bors bors bot merged commit 9dfa7dc into gfx-rs:master Jun 2, 2020
@DavidPeicho DavidPeicho deleted the feature/destroy-render-pipeline branch July 11, 2020 16:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants