Version 26.0.2 #7998
Merged
Version 26.0.2 #7998
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull Request Overview
This PR releases version 26.0.2 with critical bug fixes for Vulkan swapchain handling and framebuffer caching. The changes address validation errors with the latest Vulkan SDK and resolve flickering/crashing issues on AMD devices and Renderdoc due to incorrect caching when drivers reuse handles.
- Major refactoring of swapchain semaphore management by splitting acquire and present semaphores into separate structures
- Introduction of resource identity factories to provide unique IDs for Vulkan resources to prevent handle reuse issues
- API change requiring
&selfparameter intexture_from_rawmethod for generating unique identities
Reviewed Changes
Copilot reviewed 7 out of 7 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| wgpu-hal/src/vulkan/mod.rs | Major refactoring of swapchain semaphore structures and addition of resource identity system |
| wgpu-hal/src/vulkan/instance.rs | Updates to swapchain acquisition logic to use new semaphore structures |
| wgpu-hal/src/vulkan/device.rs | Addition of identity generation for textures and texture views, API change to texture_from_raw |
| wgpu-hal/src/vulkan/command.rs | Updates to framebuffer and texture view handling to use identity-based keys |
| wgpu-hal/src/vulkan/adapter.rs | Initialization of resource identity factories |
| Cargo.toml | Version bump to 26.0.2 |
| CHANGELOG.md | Documentation of bug fixes and breaking change warning |
| /// that to index it. | ||
| /// | ||
| /// Before we pass this to [`vkAcquireNextImageKHR`], we ensure that we wait on | ||
| /// the submission indicated by [`previously_used_submission_index`]. This enusres |
There was a problem hiding this comment.
Spelling error: 'enusres' should be 'ensures'.
Suggested change
| /// the submission indicated by [`previously_used_submission_index`]. This enusres | |
| /// the submission indicated by [`previously_used_submission_index`]. This ensures |
Copilot uses AI. Check for mistakes.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.