Fix separate depth stencil read-only state#9763
Open
beicause wants to merge 14 commits into
Open
Conversation
e6bc7cd to
37466b4
Compare
37466b4 to
81a1ea0
Compare
841df8a to
def3cf3
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Connections
Fixes #5231.
Fixes #8705.
Description
Fix separate depth stencil read-only state on vulkan and dx12 (metal seems already works).
Splits
DEPTH_STENCIL_READ/DEPTH_STENCIL_WRITETextureUses into separate depth and stencil states. On vulkan, it needsVK_IMAGE_LAYOUT_DEPTH_READ_ONLY_STENCIL_ATTACHMENT_OPTIMALandVK_IMAGE_LAYOUT_DEPTH_ATTACHMENT_STENCIL_READ_ONLY_OPTIMALwhich requires vulkan 1.1 orVK_KHR_maintenance2.Additionally, we internally use
VK_ATTACHMENT_STORE_OP_NONE(or its variants provided by extensions) to avoid theSYNC_HAZARD_WRITE_AFTER_WRITEvalidation error. IfVK_ATTACHMENT_STORE_OP_NONEis not supported, we have to insert barrier with write access flag for readonly depth stencil to avoid that error.Testing
Squash or Rebase?
Squash
Checklist
wgpumay be affected behaviorally.CHANGELOG.mdentries for the user-facing effects of this change are present.TODO: