Skip to content

Conversation

ggerganov
Copy link
Member

@ggerganov ggerganov commented Apr 22, 2025

  • No longer include ./src as public path in libllama
  • Move examples/llama-gbnf-validator -> tests/test-gbnf-validator
  • Move examples/llama-quantize-stats -> tests/test-quantize-stats

With this change, examples no longer include files from ./src.

@github-actions github-actions bot added testing Everything test related examples labels Apr 22, 2025
@slaren
Copy link
Member

slaren commented Apr 24, 2025

This should also be changed to PRIVATE, making it public may force applications to use C++17.

target_compile_features (llama PUBLIC cxx_std_17) # don't bump

@ggerganov ggerganov requested a review from slaren April 24, 2025 12:45
@ggerganov ggerganov merged commit 13b4548 into master Apr 24, 2025
52 of 54 checks passed
@ggerganov ggerganov deleted the gg/llama-inc-private branch April 24, 2025 13:00
pockers21 pushed a commit to pockers21/llama.cpp that referenced this pull request Apr 28, 2025
* cmake : do not include ./src as public for libllama

ggml-ci

* cmake : rework tests

ggml-ci

* llguidance : remove unicode include

ggml-ci

* cmake : make c++17 private

ggml-ci
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
examples testing Everything test related
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants