Server: allow immediate reuse of http port#19763
Conversation
|
This seems to break all windows build configurations |
|
Windows builds failed because the value for the socket flag is an int, and it can't be interpreted as a const char. The variable is now changed to a const char. Building succeeds on Linux, as well as using Mingw for Windows. |
|
|
@Green-Sky thanks a lot for the comment and link to the docs. I agree that using I investigated this further, and using |
|
I restarted the failed CI, seems to be unrelated to this change. will merge this once everything is green. @Green-Sky feel free to take a quick look |
|
The same workflow failed twice for the same reason, there should be a problem with this PR: https://github.com/ggml-org/llama.cpp/actions/runs/22354279984/job/64980570539?pr=19763 |
|
@ngxson indeed. Looking at that test it does use streaming, so most likely touching the same code path. We will need to investigate better what is going on. |
4d7c07a to
72a30b0
Compare
|
I rebased on to the master branch yesterday, and the test that failed before is passing - both locally and in CI: There are some other CI test failures, but those seems unrelated to this PR. |
|
Doesn't this conflict with #21056 ? |
|
@ServeurpersoCom I believe you are correct. When I made this change that flag and code block did not exist. Let me refactor this PR to properly handle the flags. |
|
Looking into this now, we see #21056 introduced the Because |
|
I tested with both this branch as well as b8808 from the master branch. The original problem is solved, because #21056 intriduced |
Add the SO_REUSEADDR flag to the http port, similar to what is done on the GRPC port here.
Related:
AI disclosure: Copilot (Claude Sonnet 4.5) was used to triage and fix the issue.