Skip to content

ci: pin external actions to exact commit SHA#21033

Merged
ngxson merged 1 commit into
ggml-org:masterfrom
ngxson:xsn/ci_pin_ext_sha
Mar 26, 2026
Merged

ci: pin external actions to exact commit SHA#21033
ngxson merged 1 commit into
ggml-org:masterfrom
ngxson:xsn/ci_pin_ext_sha

Conversation

@ngxson

@ngxson ngxson commented Mar 26, 2026

Copy link
Copy Markdown
Collaborator

Overview

Pin actions to full commit SHA, except for:

  • Official actions
  • ggml-org actions

Requirements

  • I have read and agree with the contributing guidelines
  • AI usage disclosure: YES, it is a repetitive task, so I used AI. But I manually validated the output

@ngxson
ngxson requested a review from a team as a code owner March 26, 2026 15:40
@github-actions github-actions Bot added the devops improvements to build systems and github actions label Mar 26, 2026
steps:
- uses: actions/checkout@v6
- uses: editorconfig-checker/action-editorconfig-checker@v2
- uses: editorconfig-checker/action-editorconfig-checker@840e866d93b8e032123c23bac69dece044d4d84c # v2.2.0

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
- uses: editorconfig-checker/action-editorconfig-checker@840e866d93b8e032123c23bac69dece044d4d84c # v2.2.0
- uses: editorconfig-checker/action-editorconfig-checker@840e866d93b8e032123c23bac69dece044d4d84c # v2

We should comment what the old tag was rather than what the new hash points to.

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
- uses: editorconfig-checker/action-editorconfig-checker@840e866d93b8e032123c23bac69dece044d4d84c # v2.2.0
- uses: editorconfig-checker/action-editorconfig-checker@d2ed4fd072ae6f887e9407c909af0f585d2ad9f4 # v2

In this case, do you think it's better to also pin to the exact commit of v2 tag? https://github.com/editorconfig-checker/action-editorconfig-checker/releases/tag/v2

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No, the latest at this time is fine (and v2.2.0 upgrades this to Node 24, which is required soon).

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In that case, I think keeping v2.2.0 will be more clear, right? Release tag: https://github.com/editorconfig-checker/action-editorconfig-checker/releases/tag/v2.2.0 with commit editorconfig-checker/action-editorconfig-checker@840e866

Changing it to just v2 means we use the v2 tag, unfortunately it doesn't mean v2.*

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah, ok, I just assumed it was like the other tags that gets bumped.

@ngxson
ngxson merged commit 8c60b8a into ggml-org:master Mar 26, 2026
6 checks passed
slartibardfast pushed a commit to slartibardfast/llama.cpp that referenced this pull request Apr 12, 2026
Seunghhon pushed a commit to Seunghhon/llama.cpp that referenced this pull request Apr 26, 2026
ljubomirj pushed a commit to ljubomirj/llama.cpp that referenced this pull request May 6, 2026
my-other-github-account pushed a commit to my-other-github-account/llama.cpp that referenced this pull request May 15, 2026
my-other-github-account pushed a commit to my-other-github-account/llama.cpp that referenced this pull request May 15, 2026
fewtarius pushed a commit to fewtarius/CachyLLama that referenced this pull request May 30, 2026
fukuro-kun pushed a commit to fukuro-kun/fukuro-llama-cpp-turboquant that referenced this pull request Jul 5, 2026
MrLordCat referenced this pull request in MrLordCat/llama.cpp-with-GUI Jul 16, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

devops improvements to build systems and github actions

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants