ggml-webgpu: Fix bug in FlashAttention support check#22492
Merged
Conversation
github-actions
Bot
added
ggml
ArberSephirotheca
approved these changes
Apr 29, 2026
reeselevine
added
the
merge ready
CISC
approved these changes
Apr 29, 2026
samuraieng
pushed a commit
to samuraieng/llama.cpp
that referenced
this pull request
May 6, 2026
* Fix flashattention support check for devices that don't support subgroups * set path to none if kv_tile doesn't fit
ljubomirj
pushed a commit
to ljubomirj/llama.cpp
that referenced
this pull request
May 6, 2026
* Fix flashattention support check for devices that don't support subgroups * set path to none if kv_tile doesn't fit
meh
pushed a commit
to meh/llama.cpp
that referenced
this pull request
May 10, 2026
* Fix flashattention support check for devices that don't support subgroups * set path to none if kv_tile doesn't fit
baramofme
pushed a commit
to baramofme/llama-cpp-turboquant
that referenced
this pull request
May 23, 2026
* Fix flashattention support check for devices that don't support subgroups * set path to none if kv_tile doesn't fit
winstonma
pushed a commit
to winstonma/llama.cpp
that referenced
this pull request
May 27, 2026
* Fix flashattention support check for devices that don't support subgroups * set path to none if kv_tile doesn't fit
fewtarius
pushed a commit
to fewtarius/CachyLLama
that referenced
this pull request
May 30, 2026
* Fix flashattention support check for devices that don't support subgroups * set path to none if kv_tile doesn't fit
MrLordCat
referenced
this pull request
in MrLordCat/llama.cpp-with-GUI
Jul 16, 2026
* Fix flashattention support check for devices that don't support subgroups * set path to none if kv_tile doesn't fit
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
#22199 enabled FlashAttention in the browser (non subgroup-matrix paths). However, the check in supports-op had a fallback to the subgroup-matrix path if the new tile path wasn't supported (e.g., if the browser doesn't support subgroups). This caused an error when calculating some of the shader parameters. This PR fixes the issue by returning false early in the support check if none of the flashattention variants will work.
fyi @ArberSephirotheca.
Requirements