ui: Restructure repo to use `tools/ui` folder and `ui` / `UI` / `llama-ui` / `LLAMA_UI` naming by allozaur · Pull Request #23064 · ggml-org/llama.cpp

allozaur · 2026-05-14T17:27:41Z

Overview

Additional information

Requirements

I have read and agree with the contributing guidelines
AI usage disclosure:

Copilot

Copilot wasn't able to review this pull request because it exceeds the maximum number of files (300). Try reducing the number of changed files and requesting a review from Copilot again.

ngxson · 2026-05-15T17:08:43Z

Nice, I will attempt to make the webui a linkable cmake target, will push a commit directly here

ngxson · 2026-05-15T17:51:26Z

done, let's merge if the CI passes

ngxson · 2026-05-15T19:00:03Z

btw @allozaur can you fix the merge conflict? thanks!

ngxson · 2026-05-15T19:00:28Z

no ideas why the CI wasn't triggered though 👀

allozaur · 2026-05-15T19:01:41Z

btw @allozaur can you fix the merge conflict? thanks!

yes, doing it right now!

…ui` directory

…older + use cmake npm build instead of downloading ui-build.yml artifacts in CI

allozaur · 2026-05-15T23:54:06Z

@CISC please merge once you have re-approved and are happy with the checks

allozaur · 2026-05-16T00:02:19Z

Oki, on a previous run 51/52 checks succeeded and the only one that did not, had been cancelled due to a newer commit with the fix from code suggestion from @CISC.

I think we're good to merge.

…a-ui` / `LLAMA_UI` naming (ggml-org#23064) * webui: Move static build output from `tools/server/public` to `build/ui` directory * refactor: Move to `tools/ui` * refactor: rename CMake variables and preprocessor defines - Rename LLAMA_BUILD_WEBUI -> LLAMA_BUILD_UI (old kept as deprecated) - Rename LLAMA_USE_PREBUILT_WEBUI -> LLAMA_USE_PREBUILT_UI (old kept as deprecated) - Backward compat: old vars auto-forward to new ones with DEPRECATION warning - Rename internal vars: WEBUI_SOURCE -> UI_SOURCE, WEBUI_SOURCE_DIR -> UI_SOURCE_DIR, etc. - Rename HF bucket: LLAMA_WEBUI_HF_BUCKET -> LLAMA_UI_HF_BUCKET - Emit both LLAMA_BUILD_WEBUI and LLAMA_BUILD_UI preprocessor defines - Emit both LLAMA_WEBUI_DEFAULT_ENABLED and LLAMA_UI_DEFAULT_ENABLED * refactor: rename CLI flags (--webui -> --ui) with backward compat - Add --ui/--no-ui (old --webui/--no-webui kept as deprecated aliases) - Add --ui-config (old --webui-config kept as deprecated alias) - Add --ui-config-file (old --webui-config-file kept as deprecated alias) - Add --ui-mcp-proxy/--no-ui-mcp-proxy (old --webui-mcp-proxy kept as deprecated) - Add new env vars: LLAMA_ARG_UI, LLAMA_ARG_UI_CONFIG, LLAMA_ARG_UI_CONFIG_FILE, LLAMA_ARG_UI_MCP_PROXY - C++ struct fields: params.ui, params.ui_config_json, params.ui_mcp_proxy added alongside old fields - Backward compat: old fields synced to new ones in g_params_to_internals * refactor: update C++ server internals with backward compat - Rename json_webui_settings -> json_ui_settings (both kept in server_context_meta) - Rename params.webui usage -> params.ui (both synced, old still works) - JSON API emits both "ui"/"ui_settings" and "webui"/"webui_settings" keys - Server routes use params.ui_mcp_proxy || params.webui_mcp_proxy - Preprocessor guards use #if defined(LLAMA_BUILD_UI) || defined(LLAMA_BUILD_WEBUI) * refactor: rename CI/CD workflows, artifacts, and build script - Rename webui-build.yml -> ui-build.yml; artifact webui-build -> ui-build - Rename webui-publish.yml -> ui-publish.yml; var HF_BUCKET_WEBUI_STATIC_OUTPUT -> HF_BUCKET_UI_STATIC_OUTPUT - Rename server-webui.yml -> server-ui.yml; job webui-build/checks -> ui-build/checks - Update server.yml: job/artifact refs webui-build -> ui-build - Update release.yml: all webui-build/publish refs -> ui-build/publish; HF_TOKEN_WEBUI_STATIC_OUTPUT -> HF_TOKEN_UI_STATIC_OUTPUT - Update server-self-hosted.yml: webui-build -> ui-build - Update build-self-hosted.yml: HF_WEBUI_VERSION -> HF_UI_VERSION - Rename webui-download.cmake -> ui-download.cmake (internal refs updated) - Update labeler.yml: server/webui -> server/ui path label * docs: update CODEOWNERS and server README docs - Update CODEOWNERS: team ggml-org/llama-webui -> ggml-org/llama-ui, path /tools/server/webui/ -> /tools/ui/ - Update server README.md: CLI tables show --ui flags with deprecated --webui aliases - Update server README-dev.md: "WebUI" -> "UI", paths updated to tools/ui/ * fix: Small fixes for UI build * fix: CMake.txt syntax * chore: Formatting * fix: `.editorconfig` for llama-ui * chore: Formatting * refactor: Use `APP_NAME` in Error route * refactor: Cleanup * refactor: Single migration service * make llama-ui a linkable target * fix: UI Build output * fix: Missing change * fix: separate llama-ui npm build output into build/tools/ui/dist subfolder + use cmake npm build instead of downloading ui-build.yml artifacts in CI * refactor: UI workflows cleanup --------- Co-authored-by: Xuan Son Nguyen <son@huggingface.co>

yuannan · 2026-05-17T11:35:17Z

can you update the files in .devops as well please?

allozaur · 2026-05-17T13:19:23Z

can you update the files in .devops as well please?

which ones? i believe all references to legacy tools/server/webui and tools/server/public folders are not present in the repo anymore

yuannan · 2026-05-17T16:20:39Z

can you update the files in .devops as well please?

which ones? i believe all references to legacy tools/server/webui and tools/server/public folders are not present in the repo anymore

oh okay, I wasn't sure of this as this repo also has some nix files, but if you believe so then just ignore this comment.

…a-ui` / `LLAMA_UI` naming (ggml-org#23064) * webui: Move static build output from `tools/server/public` to `build/ui` directory * refactor: Move to `tools/ui` * refactor: rename CMake variables and preprocessor defines - Rename LLAMA_BUILD_WEBUI -> LLAMA_BUILD_UI (old kept as deprecated) - Rename LLAMA_USE_PREBUILT_WEBUI -> LLAMA_USE_PREBUILT_UI (old kept as deprecated) - Backward compat: old vars auto-forward to new ones with DEPRECATION warning - Rename internal vars: WEBUI_SOURCE -> UI_SOURCE, WEBUI_SOURCE_DIR -> UI_SOURCE_DIR, etc. - Rename HF bucket: LLAMA_WEBUI_HF_BUCKET -> LLAMA_UI_HF_BUCKET - Emit both LLAMA_BUILD_WEBUI and LLAMA_BUILD_UI preprocessor defines - Emit both LLAMA_WEBUI_DEFAULT_ENABLED and LLAMA_UI_DEFAULT_ENABLED * refactor: rename CLI flags (--webui -> --ui) with backward compat - Add --ui/--no-ui (old --webui/--no-webui kept as deprecated aliases) - Add --ui-config (old --webui-config kept as deprecated alias) - Add --ui-config-file (old --webui-config-file kept as deprecated alias) - Add --ui-mcp-proxy/--no-ui-mcp-proxy (old --webui-mcp-proxy kept as deprecated) - Add new env vars: LLAMA_ARG_UI, LLAMA_ARG_UI_CONFIG, LLAMA_ARG_UI_CONFIG_FILE, LLAMA_ARG_UI_MCP_PROXY - C++ struct fields: params.ui, params.ui_config_json, params.ui_mcp_proxy added alongside old fields - Backward compat: old fields synced to new ones in g_params_to_internals * refactor: update C++ server internals with backward compat - Rename json_webui_settings -> json_ui_settings (both kept in server_context_meta) - Rename params.webui usage -> params.ui (both synced, old still works) - JSON API emits both "ui"/"ui_settings" and "webui"/"webui_settings" keys - Server routes use params.ui_mcp_proxy || params.webui_mcp_proxy - Preprocessor guards use #if defined(LLAMA_BUILD_UI) || defined(LLAMA_BUILD_WEBUI) * refactor: rename CI/CD workflows, artifacts, and build script - Rename webui-build.yml -> ui-build.yml; artifact webui-build -> ui-build - Rename webui-publish.yml -> ui-publish.yml; var HF_BUCKET_WEBUI_STATIC_OUTPUT -> HF_BUCKET_UI_STATIC_OUTPUT - Rename server-webui.yml -> server-ui.yml; job webui-build/checks -> ui-build/checks - Update server.yml: job/artifact refs webui-build -> ui-build - Update release.yml: all webui-build/publish refs -> ui-build/publish; HF_TOKEN_WEBUI_STATIC_OUTPUT -> HF_TOKEN_UI_STATIC_OUTPUT - Update server-self-hosted.yml: webui-build -> ui-build - Update build-self-hosted.yml: HF_WEBUI_VERSION -> HF_UI_VERSION - Rename webui-download.cmake -> ui-download.cmake (internal refs updated) - Update labeler.yml: server/webui -> server/ui path label * docs: update CODEOWNERS and server README docs - Update CODEOWNERS: team ggml-org/llama-webui -> ggml-org/llama-ui, path /tools/server/webui/ -> /tools/ui/ - Update server README.md: CLI tables show --ui flags with deprecated --webui aliases - Update server README-dev.md: "WebUI" -> "UI", paths updated to tools/ui/ * fix: Small fixes for UI build * fix: CMake.txt syntax * chore: Formatting * fix: `.editorconfig` for llama-ui * chore: Formatting * refactor: Use `APP_NAME` in Error route * refactor: Cleanup * refactor: Single migration service * make llama-ui a linkable target * fix: UI Build output * fix: Missing change * fix: separate llama-ui npm build output into build/tools/ui/dist subfolder + use cmake npm build instead of downloading ui-build.yml artifacts in CI * refactor: UI workflows cleanup --------- Co-authored-by: Xuan Son Nguyen <son@huggingface.co>

github-actions Bot added build Compilation issues script Script related server/webui examples devops improvements to build systems and github actions server labels May 14, 2026

allozaur force-pushed the allozaur/llama-ui-restructuring branch 4 times, most recently from 8c30b16 to bcd3694 Compare May 15, 2026 11:15

allozaur commented May 15, 2026

View reviewed changes

allozaur self-assigned this May 15, 2026

allozaur marked this pull request as ready for review May 15, 2026 15:31

allozaur requested a review from ggerganov as a code owner May 15, 2026 15:31

Copilot AI review requested due to automatic review settings May 15, 2026 15:31

allozaur requested review from a team as code owners May 15, 2026 15:31

Copilot AI reviewed May 15, 2026

ServeurpersoCom approved these changes May 15, 2026

View reviewed changes

allozaur mentioned this pull request May 15, 2026

webui: fix theme from --webui-config-file not applied on first load (fresh localStorage) #22902

Merged

allozaur commented May 15, 2026

View reviewed changes

Comment thread tools/ui/scripts/vite-plugin-llama-cpp-build.ts Outdated

allozaur added 2 commits May 15, 2026 21:15

webui: Move static build output from tools/server/public to `build/…

0fd4add

…ui` directory

refactor: Move to tools/ui

d823e00

ngxson and others added 2 commits May 15, 2026 21:16

make llama-ui a linkable target

0d82ef3

fix: UI Build output

6676b83

allozaur force-pushed the allozaur/llama-ui-restructuring branch from d1aa557 to 6676b83 Compare May 15, 2026 19:30

allozaur requested a review from ngxson May 15, 2026 19:33

fix: Missing change

1ddb2bf

ngxson approved these changes May 15, 2026

View reviewed changes

fix: separate llama-ui npm build output into build/tools/ui/dist subf…

bef46b4

…older + use cmake npm build instead of downloading ui-build.yml artifacts in CI

allozaur requested a review from CISC May 15, 2026 23:20

CISC approved these changes May 15, 2026

View reviewed changes

Comment thread .github/workflows/release.yml Outdated

refactor: UI workflows cleanup

508a2c5

allozaur requested a review from CISC May 15, 2026 23:53

CISC approved these changes May 15, 2026

View reviewed changes

allozaur merged commit 59778f0 into ggml-org:master May 16, 2026
52 checks passed

allozaur deleted the allozaur/llama-ui-restructuring branch May 16, 2026 09:55

TerrorJack mentioned this pull request May 17, 2026

llama-cpp: 9080 -> 9190 NixOS/nixpkgs#521213

Merged

13 tasks

UNDEFINED-BEHAVIOR mentioned this pull request May 17, 2026

Compile bug: 9191 fails to build: string sub-command LENGTH requires two arguments. #23194

Closed

Blist mentioned this pull request May 17, 2026

Compile bug: Nixos, flake : webui no such file or directory #23164

Closed

Uh oh!

Conversation

allozaur commented May 14, 2026

Overview

Additional information

Requirements

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Uh oh!

ngxson commented May 15, 2026

Uh oh!

ngxson commented May 15, 2026

Uh oh!

ngxson commented May 15, 2026

Uh oh!

ngxson commented May 15, 2026

Uh oh!

allozaur commented May 15, 2026

Uh oh!

Uh oh!

Uh oh!

allozaur commented May 15, 2026

Uh oh!

allozaur commented May 16, 2026

Uh oh!

Uh oh!

yuannan commented May 17, 2026

Uh oh!

allozaur commented May 17, 2026

Uh oh!

yuannan commented May 17, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants