Skip to content

webui: Use lowercase hash for HF checksum check#23107

Merged
allozaur merged 1 commit into
ggml-org:masterfrom
ozars:webui-checksum
May 15, 2026
Merged

webui: Use lowercase hash for HF checksum check#23107
allozaur merged 1 commit into
ggml-org:masterfrom
ozars:webui-checksum

Conversation

@ozars

@ozars ozars commented May 15, 2026

Copy link
Copy Markdown
Contributor

https://huggingface.co/buckets/ggml-org/llama-ui/tree/latest/checksums.txt contains lowercase checksums.

Overview

Checksum check in webui-download.cmake converts checksums to uppercase before comparing them to those in remotely downloaded checksums.txt file. However, the remote file contains lowercase checksums. This PR simply replaces TOUPPER logic with TOLOWER.

Requirements

@ozars

ozars commented May 15, 2026

Copy link
Copy Markdown
Contributor Author

cc @allozaur @CISC

@github-actions github-actions Bot added the script Script related label May 15, 2026

@CISC CISC left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice catch, thanks.

@allozaur
allozaur merged commit 1348f67 into ggml-org:master May 15, 2026
46 checks passed
@ozars
ozars deleted the webui-checksum branch May 15, 2026 21:21
dandm1 pushed a commit to dandm1/llama.cpp that referenced this pull request May 16, 2026
ArberSephirotheca pushed a commit to ArberSephirotheca/llama.cpp that referenced this pull request May 19, 2026
baramofme pushed a commit to baramofme/llama-cpp-turboquant that referenced this pull request May 23, 2026
winstonma pushed a commit to winstonma/llama.cpp that referenced this pull request May 27, 2026
fewtarius pushed a commit to fewtarius/CachyLLama that referenced this pull request May 30, 2026
bong-water-water-bong pushed a commit to bong-water-water-bong/llama.cpp that referenced this pull request Jul 15, 2026
Keep backend-only platform jobs independent from embedded WebUI assets, preserve dedicated WebUI coverage, and stop generation when provisioning is incomplete.

Based on upstream llama.cpp commit(s):
- 0c3e4fc - fix: Propagate version tag to WebUI asset download in self-hosted CI (ggml-org#23051) - Aleksander Grygier <aleksander.grygier@gmail.com>
- 1348f67 - webui: Use lowercase hash for HF checksum check (ggml-org#23107) - Omer Ozarslan <omerfaruko@gmail.com>

Co-authored-by: Aleksander Grygier <aleksander.grygier@gmail.com>
Co-authored-by: Sigbjørn Skjæret <sigbjorn.skjaeret@scala.com>
Co-authored-by: Omer Ozarslan <omerfaruko@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

script Script related

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants