server : add last-5-seconds generation speed display#24291
Merged
Conversation
Collaborator
|
IMO a sliding window is quite overkill. a rolling windows that is cleared each 5s will be much more simple |
Contributor
Author
|
@ngxson Sure! Replaced with a static 5-second window, no extra allocations. |
Collaborator
|
cc @ggerganov : not exactly sure if you think this feature would be useful ? |
ggerganov
approved these changes
Jun 18, 2026
ggerganov
left a comment
Member
There was a problem hiding this comment.
I think it's useful to have this info.
ngxson
approved these changes
Jun 18, 2026
papamoose
pushed a commit
to papamoose/llama.cpp
that referenced
this pull request
Jun 27, 2026
* server : add last-5-seconds generation speed display * cont : clean-up --------- Co-authored-by: Georgi Gerganov <ggerganov@gmail.com>
adrianhoehne
pushed a commit
to adrianhoehne/llama.cpp
that referenced
this pull request
Jul 5, 2026
* server : add last-5-seconds generation speed display * cont : clean-up --------- Co-authored-by: Georgi Gerganov <ggerganov@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Overview
This PR adds a
tg(last 5s)display to the server token generation speed log.I noticed
tgis computed as an average over the entire computation, which, for instance on my Macbook, doesn't really tell the full story (other than that yes, speed decreases as the context grows longer).Example:
Requirements