Skip to content

docs: fix export-lora --lora-scaled syntax#24703

Merged
ngxson merged 1 commit into
ggml-org:masterfrom
kkkzbh:docs/export-lora-lora-scaled-syntax
Jun 18, 2026
Merged

docs: fix export-lora --lora-scaled syntax#24703
ngxson merged 1 commit into
ggml-org:masterfrom
kkkzbh:docs/export-lora-lora-scaled-syntax

Conversation

@kkkzbh

@kkkzbh kkkzbh commented Jun 16, 2026

Copy link
Copy Markdown
Contributor

Overview

While setting up a LoRA workflow, I noticed that tools/export-lora/README.md no longer matches the current llama-export-lora CLI behavior.

The README documents --lora-scaled FNAME S, but the current help output and parser expect --lora-scaled FNAME:SCALE,....

This PR updates the README option description and multi-LoRA example to use the current syntax. No behavior is changed.

Additional information

This appears to have become stale after #18056 migrated repeated arguments to comma-separated syntax.

Testing

  • Ran llama-export-lora --help
  • Verified --lora-scaled foo.gguf 0.5 fails argument parsing with lora-scaled format: FNAME:SCALE
  • Verified --lora-scaled foo.gguf:0.5 passes argument parsing and proceeds to model loading

Requirements

  • I have read and agree with the contributing guidelines
  • AI usage disclosure: YES
  • I used Codex as an assistive tool to inspect the current CLI help/source and discuss this documentation-only update. I manually reviewed the README diff and understand the submitted change.

@ngxson ngxson merged commit 7b6c5a2 into ggml-org:master Jun 18, 2026
3 checks passed
@kkkzbh kkkzbh deleted the docs/export-lora-lora-scaled-syntax branch June 18, 2026 14:48
papamoose pushed a commit to papamoose/llama.cpp that referenced this pull request Jun 27, 2026
adrianhoehne pushed a commit to adrianhoehne/llama.cpp that referenced this pull request Jul 5, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants