Skip to content

docker : build the UI#24794

Merged
ngxson merged 2 commits into
ggml-org:masterfrom
aldehir:docker-build
Jun 19, 2026
Merged

docker : build the UI#24794
ngxson merged 2 commits into
ggml-org:masterfrom
aldehir:docker-build

Conversation

@aldehir

@aldehir aldehir commented Jun 19, 2026

Copy link
Copy Markdown
Contributor

Overview

Fixes #24726 by building the UI separately.

Requirements

@aldehir aldehir requested review from a team and ngxson as code owners June 19, 2026 08:13
@github-actions github-actions Bot added the devops improvements to build systems and github actions label Jun 19, 2026
Comment thread .github/workflows/docker.yml Outdated
@ngxson ngxson merged commit 38724ab into ggml-org:master Jun 19, 2026
3 checks passed
@ngxson

ngxson commented Jun 19, 2026

Copy link
Copy Markdown
Collaborator

Publishing new images: https://github.com/ggml-org/llama.cpp/actions/runs/27828808113

@maikelthedev

Copy link
Copy Markdown

Thank you all involved

@ngxson

ngxson commented Jun 19, 2026

Copy link
Copy Markdown
Collaborator

seems like one of the build fails because the native module is not available on that platform: https://github.com/ggml-org/llama.cpp/actions/runs/27828808113/job/82360189883

image

for details: this is because some node modules use native code (usually in c++ / go / rust / etc), so the pre-built package should be available for that platform, which doesn't seem to be the case for s390x

@CISC

CISC commented Jun 19, 2026

Copy link
Copy Markdown
Member

for details: this is because some node modules use native code (usually in c++ / go / rust / etc), so the pre-built package should be available for that platform, which doesn't seem to be the case for s390x

A better solution is perhaps to build UI (once) before the Docker images and copy the artifact into each image?

@aldehir

aldehir commented Jun 19, 2026

Copy link
Copy Markdown
Contributor Author

I thought about that but then it doesn't make the Dockerfiles stand-alone if one wanted to build them directly. Seems it's the only option. The s390x build was the only one I couldn't test in my own repo.

@ngxson

ngxson commented Jun 19, 2026

Copy link
Copy Markdown
Collaborator

another option is to disable lightningcss on the vite/svelte build, not I'm not 100% if that is a configurable option

@CISC

CISC commented Jun 19, 2026

Copy link
Copy Markdown
Member

I thought about that but then it doesn't make the Dockerfiles stand-alone if one wanted to build them directly. Seems it's the only option. The s390x build was the only one I couldn't test in my own repo.

Hm, true, let's leave the others as-is and do this for s390x. If the dist folder is missing when user is building it will try to download it like before.

jimbothigpen added a commit to jimbothigpen/llama.cpp that referenced this pull request Jun 20, 2026
Absorbs PRs ggml-org#24821 ggml-org#24796 ggml-org#24779 ggml-org#24817 ggml-org#23168 ggml-org#24787 ggml-org#24801 ggml-org#24794
ggml-webgpu F16 toggles, server router/agent refactor, cpp-httplib 0.48.0,
utf8 windows fix, docker UI build. No conflicts with our custom backends.
papamoose pushed a commit to papamoose/llama.cpp that referenced this pull request Jun 27, 2026
* docker : build the UI

* cont : use existing APP_VERSION
adrianhoehne pushed a commit to adrianhoehne/llama.cpp that referenced this pull request Jul 5, 2026
* docker : build the UI

* cont : use existing APP_VERSION
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

devops improvements to build systems and github actions

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Misc. bug: Web UI is gone (b9680)

4 participants