vulkan : check src0 type in GGML_OP_SET_ROWS to avoid failures due to unimplemented f16 support#25351
Merged
am17an merged 2 commits intoJul 7, 2026
Conversation
… unimplemented f16 support
0cc4m
approved these changes
Jul 6, 2026
| default: | ||
| return false; | ||
| } | ||
| } else { |
ggerganov
approved these changes
Jul 6, 2026
Contributor
|
@ggerganov Do you know what's up with the ubuntu-llvmpipe runner? It consistently fails with ILLEGAL errors, e.g. I don't think we caused that. |
Member
No, there is nothing obvious. Have you tried deleting the ccache? |
Contributor
|
I'm not familiar with the runner, where is the cache controlled? |
Member
|
Not sure if you have access to this page, but it's here: You can simply delete all the caches and see if it helps. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Overview
This PR adds
src0type check forGGML_OP_SET_ROWSinggml_backend_vk_device_supports_op()to handle case with non-f32src0as unsupported (for now).Additional information
Needed to avoid Vulkan test-backend-op failures when #25344 is merged.
Requirements