Command line args bounds checking #424
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
anzz1
requested review from
ggerganov,
sw,
blackhole89 and
Green-Sky
and removed request for
ggerganov
Green-Sky
approved these changes
Mar 23, 2023
Green-Sky
requested changes
Mar 23, 2023
|
Hm it got stuck on "change requested" even when it's resolved? |
Green-Sky
approved these changes
Mar 23, 2023
wdym? |
sw
approved these changes
Mar 23, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bound check command line argument parameters so it doesn't crash / do out-of-bounds read when entering empty param.
Outputs a "invalid parameter" error in this case.
before: "./main -r " = crash