Ruby binding: handle negative value in padding #3389
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
this might happen depending on the way the $stderr.winsize is defined. If the expression "$stderr.winsize[1] - line.size" in Line 114 gets negative, we will get a "negative argument" exception in the padding calculation
bygreencn
added a commit
to bygreencn/whisper.cpp
that referenced
this pull request
Sep 24, 2025
* ggerganov/master: (92 commits) ggml : Fix MKL detection by quoting BLAS_INCLUDE_DIRS (ggml-org#3426) whisper : prefer curl over wget in download scripts (ggml-org#3409) ci : remove brew installation of cmake for macos-latest (ggml-org#3408) tests : use CMake definitions for model/sample paths (ggml-org#3406) Handle negative value in padding (ggml-org#3389) models : update`./models/download-ggml-model.cmd` to allow for tdrz download (ggml-org#3381) talk-llama : sync llama.cpp sync : ggml ggml: Add initial WebGPU backend (llama/14521) ggml : initial zDNN backend (llama/14975) common : handle mxfp4 enum ggml-quants : fix make_qp_quants NANs and IQ1 assertion errors (llama/15379) vulkan: disable spirv-opt for bfloat16 shaders (llama/15352) vulkan: Use larger workgroups for mul_mat_vec when M is small (llama/15355) vulkan: support sqrt (llama/15370) vulkan: Optimize argsort (llama/15354) vulkan: fuse adds (llama/15252) vulkan: Support mul_mat_id with f32 accumulators (llama/15337) vulkan: Add missing bounds checking to scalar/coopmat1 mul_mat_id (llama/15334) OpenCL: add initial FA support (llama/14987) ...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
this might happen depending on the way the $stderr.winsize is defined.
If the expression "$stderr.winsize[1] - line.size" in Line 114 gets negative, we will get a "negative argument" exception in the padding calculation