.aginore not ignoring filenames containing several dots

If my .agignore file contains:

*.htm

And if I have two files a.htm and a.b.htm, the latter is not ignored by .agignore.

Here's an example:

$ echo "needle" > haystack.htm
$ echo "needle" > haystack.a.htm
$ echo "*.htm" > .agignore
$ ag needle
haystack.a.htm
1:needle

I found out that using **.htm works in this case, but if this is intentional, it is very uninituitive, especially since it does not follow .gitignore syntax. I'd recommend in this case mentioning this explicitly in https://github.com/ggreer/the_silver_searcher/wiki/Advanced-Usage, which says that:

.agignore uses the same patterns as .gitignore and .hgignore.

[JIghtuse]

It works on 0.30.0. git bisect told me it was intentional change indeed (introduced in d3a5de4). I don't quite get why ag should behave like this, but fix is trivial - revert commit to use strrchr instead of strchr. I can sent PR if @ggreer agrees to accept it.

[epmatsw]

Ugh, that's my bad on that one. The issue that was fixed was that you couldn't ignore *.min.js files, because it would just get the .js, which doesn't match any ignored extension. Now, it's getting .b.htm, which again doesn't match any extension. It seems like the fix is going to have to be more nuanced than my change :(

[fuzzy76]

As a web developer, not being able to ignore .min.js files means it is completely broken :(

[brianpeiris]

FYI, the workaround for this is to add *.a.htm or *.*.htm to your .agignore.

[fuzzy76]

Why aren't you comparing the entire filename when matching against wildcards? I'm pretty sure that's what git does when parsing .gitignore

[brianpeiris]

@fuzzy76 It's just a bug but there are performance concerns that make the fix a bit complicated. @ggreer mentions it in his blog post: http://geoff.greer.fm/2014/10/13/help-me-get-to-ag-10/

[jean]

Argh. Kind of amazed to realize that glob matching (e.g. *.min.*) is "special" in ag ..

[denilsonsa]

I believe this issue was fixed by 221e4c2

[spookylukey]

This issue is still not fixed. With current master, if, for example, you have *.min.js in your .ignore, then foo.min.js is skipped, but foo-1.0.min.js is not. So, jquery-x.y.z.min.js for example, which is very common, is not skipped.

[spookylukey]

For those who want a workaround, version 0.28.0 is the last released version that doesn't have this bug.

[p-phillips]

You can also add a workaround to your .ignore files by using this type of pattern:

  *[*\.]js
  *[*\.]html                                                                                                                                
  *[*\.]css 

Presumably this will continue to work once the fix is in place.