-
Notifications
You must be signed in to change notification settings - Fork 0
Feature/inbound protocol gdev 714 #4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* init from ghga_service_chassis_lib Initialize with apache kafka functionality from the ghga_service_chassis_lib. * eventpub protocol draft * add kafka-based publisher and example application * rename to hexkit * adapt setup.cfg * add description * adapt version * simplified tests suite * add tests * update from template * fix mandatory files * fix setup * fix * disable pr target check * use coveralls * update dep-injector version * fix coveralls * add coverage badge * save * Update examples/stream_calc/core/calc.py Co-authored-by: Christoph Zwerschke <[email protected]> * Update examples/stream_calc/core/calc.py Co-authored-by: Christoph Zwerschke <[email protected]> * Update examples/stream_calc/ports/__init__.py Co-authored-by: Christoph Zwerschke <[email protected]> * cleanup unneeded file * correct doc string * delete container name * renamed to translators * added int * ensure ascii * make KafkaProducer mockable * avoid random * fix imports * fix formatting * rename Proto * added unit test mocking kafka producer * rename ports * fix naming * save * save * renamed ports * flatten example import logic * rename payload, key, type, and topic * refactor json types * restructure hexkit * save Co-authored-by: Christoph Zwerschke <[email protected]>
Cito
approved these changes
Apr 19, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me, I like the integration and unit tests. Just some typos to fix.
Co-authored-by: Christoph Zwerschke <[email protected]>
Co-authored-by: Christoph Zwerschke <[email protected]>
Co-authored-by: Christoph Zwerschke <[email protected]>
Co-authored-by: Christoph Zwerschke <[email protected]>
Co-authored-by: Christoph Zwerschke <[email protected]>
Co-authored-by: Christoph Zwerschke <[email protected]>
Co-authored-by: Christoph Zwerschke <[email protected]>
…m/ghga-de/hexkit into feature/inbound_protocol_GDEV-714
3529991
to
b261724
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Title for squash and merge:
Description for squash and merge: