Skip to content

Feature/inbound protocol gdev 714 #4

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 21 commits into from
Apr 20, 2022

Conversation

KerstenBreuer
Copy link
Contributor

@KerstenBreuer KerstenBreuer commented Apr 14, 2022

Title for squash and merge:

inbound event sub protocol + kafka provider (GDEV-714)

Description for squash and merge:

Added event subscription protocol and provider:
- provider based on kafka-python library
- extended example app accordingly
- includes updates from the microservice_template_repository
- not included: a test framework for use by implementing services

KerstenBreuer and others added 5 commits April 14, 2022 07:21
* init from ghga_service_chassis_lib

Initialize with apache kafka functionality from the
ghga_service_chassis_lib.

* eventpub protocol draft

* add kafka-based publisher and example application

* rename to hexkit

* adapt setup.cfg

* add description

* adapt version

* simplified tests suite

* add tests

* update from template

* fix mandatory files

* fix setup

* fix

* disable pr target check

* use coveralls

* update dep-injector version

* fix coveralls

* add coverage badge

* save

* Update examples/stream_calc/core/calc.py

Co-authored-by: Christoph Zwerschke <[email protected]>

* Update examples/stream_calc/core/calc.py

Co-authored-by: Christoph Zwerschke <[email protected]>

* Update examples/stream_calc/ports/__init__.py

Co-authored-by: Christoph Zwerschke <[email protected]>

* cleanup unneeded file

* correct doc string

* delete container name

* renamed to translators

* added int

* ensure ascii

* make KafkaProducer mockable

* avoid random

* fix imports

* fix formatting

* rename Proto

* added unit test mocking kafka producer

* rename ports

* fix naming

* save

* save

* renamed ports

* flatten example import logic

* rename payload, key, type, and topic

* refactor json types

* restructure hexkit

* save

Co-authored-by: Christoph Zwerschke <[email protected]>
@KerstenBreuer KerstenBreuer requested a review from Cito April 14, 2022 12:01
Copy link
Member

@Cito Cito left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, I like the integration and unit tests. Just some typos to fix.

@KerstenBreuer KerstenBreuer force-pushed the feature/inbound_protocol_GDEV-714 branch from 3529991 to b261724 Compare April 19, 2022 09:02
@KerstenBreuer KerstenBreuer merged commit 7d6cbb1 into main Apr 20, 2022
@KerstenBreuer KerstenBreuer deleted the feature/inbound_protocol_GDEV-714 branch April 20, 2022 13:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants