fix(managed): force pinIt value when disableOnboarding is set
#2814
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chrmod
approved these changes
Oct 27, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes a race condition in managed config handling that could cause the "Pin It" notification to reappear after being dismissed.
Issue: When managed storage becomes temporarily unavailable, locally stored options (like onboarding.pinIt) can be cleared once managed storage recovers, causing dismissed notifications to reappear in a cyclic pattern.
Root Cause: The extension relies on managed storage for configuration, but temporary failures in the managed storage API (outside our control) can cause local storage state to be reset when the connection is restored.
Impact: Users in managed environments may experience repeated "Pin It" notifications even after dismissing them, due to the managed config sync clearing local storage state during recovery cycles.