Skip to content

Plat 245 #1

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 12 commits into from
Nov 20, 2015
Merged

Plat 245 #1

merged 12 commits into from
Nov 20, 2015

Conversation

gianchub
Copy link
Owner

@mattbennett

This creates the library as agreed.

jira task

.coverage
wheelhouse
config
.env.*
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

wheelhouse, config and .env.* are all student.com specific conventions that we should leave out of here

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Probably want to add docs/build too

Copy link
Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done.

@gianchub
Copy link
Owner Author

All comments addressed.

Comparing two schemas is easy. You can verify they are the same like
this:

.. literalinclude:: ../../test/endtoend/test_example.py
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think it's helpful to show any pytest boilerplate in these "how to use it" docs. The important parts are

>>> result = compare(uri_left, uri_right)
>>> result.is_match
    True

and

>>> result = compare(uri_left, uri_right)
>>> result.is_match
    False

>>> result.dump_errors()
    {
        ...
    }

Everything else is unnecessary and risks causing confusion. People will wonder what new_db_left and new_db_right are, and whether pytest is a requirement.

Copy link
Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done.

@mattbennett
Copy link
Collaborator

This is very nice. Just a few changes to make please.

@gianchub
Copy link
Owner Author

Thank you, all comments addressed.

@mattbennett
Copy link
Collaborator

👍 awesome

mattbennett added a commit that referenced this pull request Nov 20, 2015
@mattbennett mattbennett merged commit 53e9667 into master Nov 20, 2015
@mattbennett mattbennett deleted the PLAT-245 branch November 20, 2015 05:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants