-
Notifications
You must be signed in to change notification settings - Fork 19
Plat 245 #1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Plat 245 #1
Conversation
.coverage | ||
wheelhouse | ||
config | ||
.env.* |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
wheelhouse
, config
and .env.*
are all student.com specific conventions that we should leave out of here
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Probably want to add docs/build
too
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done.
All comments addressed. |
Comparing two schemas is easy. You can verify they are the same like | ||
this: | ||
|
||
.. literalinclude:: ../../test/endtoend/test_example.py |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't think it's helpful to show any pytest boilerplate in these "how to use it" docs. The important parts are
>>> result = compare(uri_left, uri_right)
>>> result.is_match
True
and
>>> result = compare(uri_left, uri_right)
>>> result.is_match
False
>>> result.dump_errors()
{
...
}
Everything else is unnecessary and risks causing confusion. People will wonder what new_db_left
and new_db_right
are, and whether pytest is a requirement.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done.
This is very nice. Just a few changes to make please. |
Thank you, all comments addressed. |
👍 awesome |
@mattbennett
This creates the library as agreed.
jira task