Clean up some cruft files on Windows releases#2248
Merged
Conversation
Remove the cruft code signing summary file from the Windows payload zips. There's nothing interesting in this file anyway. Signed-off-by: Matthew John Cheetham <mjcheetham@outlook.com>
When building locally the gcm(user)-$RID-$VERSION.exe installer files were being written to the PayloadPath, rather than the OutputPath. Also, since we're now specifying a RID for all invocations of the project file, we should disable the appending of the RID to the OutputPath variable - we already have the RID as part of the PayloadPath (for keeping binaries separated by RID) and the resulting installer filenames also contain the RID anyway. Signed-off-by: Matthew John Cheetham <mjcheetham@outlook.com>
We assume the input paths given to the Windows layout.ps1 scripts do not have a trailing slash - we should make sure this is the case before proceeding and doing path-math with that. Signed-off-by: Matthew John Cheetham <mjcheetham@outlook.com>
mjcheetham
force-pushed
the
file-cleanup
branch
from
1c73215 to
2d4143e
Compare
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Improve the handling of output paths and build artifacts in the Windows installer build pipeline.
We accidentally started including some code signing summary report files in the output zip archives on Windows - let's delete those.
Also I noticed that local builds were now outputting the Windows installers to the payload directory, rather than the expected output path. This is because now that we specify a RID we were getting the RID appended to the output path (which would then be the same as the payload path.. what a coincidence!).
Finally let's be a bit more robust with the path-math in our layout.ps1 script - we should not assume if the path has the trailing slash or not. (Note that in MSBuild, the convention is that directory path variables should end with a slash.)