Skip to content

build-extra: add $HOME/bin to path #17

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 31, 2015
Merged

build-extra: add $HOME/bin to path #17

merged 1 commit into from
Mar 31, 2015

Conversation

nalla
Copy link
Contributor

@nalla nalla commented Mar 31, 2015

This behavior was present in the msysgit version of the /etc/profile
file. The git-extra package now adds a homepath.sh into the
/etc/profile.d directory to restore the behavior in the MSYS2
environment.

This should resolve git-for-windows/git#57.

Signed-off-by: nalla [email protected]

@@ -65,5 +65,6 @@ package() {
install -m755 create-shortcut.exe $pkgdir/$mingwdir/bin
install -m755 $startdir/git-prompt.sh $pkgdir/etc/profile.d
install -m755 $startdir/aliases.sh $pkgdir/etc/profile.d
install -m755 $startdir/homepath.sh $pkgdir/etc/profile.d

This comment was marked as off-topic.

This comment was marked as off-topic.

This behavior was present in the *msysgit* version of the `/etc/profile`
file. The `git-extra` package now adds an `env.sh` into the
`/etc/profile.d` directory to restore the behavior in the *MSYS2*
environment.

Signed-off-by: nalla <[email protected]>
@sschuberth
Copy link
Contributor

I do not like env because it says even less about what purpose the file serves.

@dscho Saying less about the current use of the file was the intention of my proposal. In exchange we do not need to create another file if we ever wanted to modify another environment variable. Think of it like e.g. Ubuntu's /etc/environment file.

@dscho
Copy link
Member

dscho commented Mar 31, 2015

If we choose a name as generic as env.sh, it takes just one other package to make the same choice to cause trouble.

No, I still prefer the homepath.sh. And I also prefer to avoid spending so much time to discuss the color of this bike shed when we still have an entire parking lot to build.

@sschuberth
Copy link
Contributor

So retain your picture: I don't think we can build an entire parking lot with poor material. Since you prefer not to spend more time discussing, the quickest thing to do is to merge as-is, which is what I'll do now.

sschuberth added a commit that referenced this pull request Mar 31, 2015
build-extra: add $HOME/bin to path
@sschuberth sschuberth merged commit 42f4fdf into git-for-windows:master Mar 31, 2015
@dscho
Copy link
Member

dscho commented Mar 31, 2015

If we spend as much time discussing the parking lot as we spend on the color of this bike shed (which BTW almost nobody will ever see), then we won't get started with anything in the way of building the parking lot for a long, long time. I am not prepared to wait for that long, so please understand I have to spend substantially less time clarifying the goals, the technical issues, and possible solutions. It would be good to keep the discussions more to the important points, for that reason. Because at the end of the day, I care about the result, not about the discussion.

@nalla nalla deleted the home-path branch March 31, 2015 08:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

XP: Comment - Path /usr/local/bin:/usr/bin:/bin: isn't on XP
3 participants