installer: add 64-bit support for ARM64 #333
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dennisameling
force-pushed
the
installer-arm64-64-bit
branch
from
94f9ea7 to
f7a3670
Compare
rimrul
reviewed
Mar 22, 2021
The Git for Windows ARM64 installation ideally should be installed in the 64-bit Program Files folder. Inno Setup 6.0 added support for 64-bit on Windows ARM64. This commit leverages this support. Signed-off-by: Dennis Ameling <[email protected]>
dennisameling
force-pushed
the
installer-arm64-64-bit
branch
from
f7a3670 to
13466bf
Compare
rimrul
approved these changes
Apr 20, 2021
dscho
approved these changes
Apr 20, 2021
Member
dscho
left a comment
dscho
left a comment
There was a problem hiding this comment.
At first, I was a bit concerned about defining INSTALLER_FILENAME_SUFFIX when we don't want any suffix, but it does seem like the cleanest solution (because unlike a proper C preprocessor, #if defined(INSTALLER_FILENAME_SUFFIX) && INSTALLER_FILENAME_SUFFIX!='' would still result in the error message Undeclared identifier: INSTALLER_FILENAME_SUFFIX.).
Member
|
@dennisameling thank you so much! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Builds further on #330
The Git for Windows ARM64 installation ideally should be installed in the 64-bit Program Files folder. Inno Setup 6.0 added support for 64-bit on Windows ARM64. This commit leverages this support.
The installation directory is correctly set to
C:\Program Files\Git:The Git Credential Manager radio buttons are enabled correctly in the 64-bit ARM64 installer: