make-file-list.sh: future-proof the pactree output parsing#596
Merged
Conversation
In c9f04bb (make-file-list: stop being confused by `>=<ver>` in the `pactree` output, 2025-02-10), this script was adjusted to account for `pactree` sometimes specifying version ranges of some dependencies. However, this change was incomplete! It only handles the version ranges that are _currently_ found in Git for Windows, but other version ranges are equally valid. What I came up with to parse a dependency in msys2/pacdb (https://github.com/msys2/pacdb) is: ```source-python _DEPENDRE = re.compile(r'([^<>=]+)(?:(<=|>=|<|>|=)(.*))?') ``` That might be more complicated than we want to use here though. (That gets you 3 match groups: the package name, the relational operator, and the version). We might just as well future-proof it by a simpler solution that nevertheless catches more package version checks. Signed-off-by: Jeremy Drake <github@jdrake.com> Signed-off-by: Johannes Schindelin <johannes.schindelin@gmx.de>
Contributor
|
👍 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
@jeremyd2019 I basically took your suggestion from #591 (comment), ghost-wrote a commit message, and opened this PR. What do you think? Okay?