Skip to content

ci: verify that the Git and Scalar executables work in Nano Server #55

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 24, 2022

Conversation

dscho
Copy link
Member

@dscho dscho commented Nov 2, 2022

It was reported in git-for-windows/git#4052 that Git for Windows v2.38.0 introduced a regression (fixed in git-for-windows/git#4074) where git.exe could no longer be run in Nano Server containers.

Let's add a workflow that verifies that Git for Windows does not regress on this in the future.

The CI run will necessarily fail at the moment, as Git for Windows v2.38.1 was released without any fix for Nano Server, and will print helpful information as to any missing symbol, as demonstrated by this run.

As demonstrated by this run (which uses the artifacts produced by a build of the PullRequest that fixes the issue), the CI run will start succeeding once we build a new Git version after merging said PR.

@dscho dscho self-assigned this Nov 2, 2022
@dscho
Copy link
Member Author

dscho commented Nov 9, 2022

Seems to work with ContainerAdministrator, too, so I'll take that one.

@dscho
Copy link
Member Author

dscho commented Nov 9, 2022

Now we have to wait before merging this PR until Git v2.38.2 is published (and hence, Git for Windows v2.38.2), or v2.39.0, or that there are more reasons than the regression on Nano Server that would justify a Git for Windows v2.38.1(2). We have to wait because the workflow runs would fail without any new mingw-w64-git version (which we traditionally integrate into git-sdk-64 only when publishing a new Git for Windows version).

It was reported in git-for-windows/git#4052
that Git for Windows v2.38.0 introduced a regression where `git.exe`
could no longer be run in Nano Server containers.

The issue was fixed in git-for-windows/git#4074

Let's add a workflow that verifies that Git for Windows does not regress
on this in the future.

Signed-off-by: Johannes Schindelin <[email protected]>
@dscho
Copy link
Member Author

dscho commented Nov 24, 2022

We have to wait because the workflow runs would fail without any new mingw-w64-git version

We now have a v2.39.0-rc0, I rebased the branch, and the test passes: https://github.com/dscho/git-sdk-64/actions/runs/3539679536/jobs/5941865217

Now I only need to fix the (unrelated) check-for-missing-dlls check before merging this here PR.

@dscho
Copy link
Member Author

dscho commented Nov 24, 2022

Now I only need to fix the (unrelated) check-for-missing-dlls check before merging this here PR.

This is the PR that does that: git-for-windows/build-extra#445

@dscho dscho merged commit 27a49aa into git-for-windows:main Nov 24, 2022
@dscho dscho deleted the test-nano-server branch November 24, 2022 11:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant