Skip to content

Git failed to build with VS2017 due to error C1083: Cannot open include file: 'openssl/ssl.h': No such file or directory #1234

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
KarenHuang2016 opened this issue Jul 12, 2017 · 5 comments
Closed

Git failed to build with VS2017 due to error C1083: Cannot open include file: 'openssl/ssl.h': No such file or directory #1234

KarenHuang2016 opened this issue Jul 12, 2017 · 5 comments
Labels
bug git
Milestone
v2.14.2

Comments

@KarenHuang2016
Copy link

Setup

  • Which version of Git for Windows are you using? Is it 32-bit or 64-bit?
    64-bit
    $ git --version --build-options
    git version 2.9.2.windows.1
    sizeof-long: 4
  • Which version of Windows are you running? Vista, 7, 8, 10? Is it 32-bit or 64-bit?
    Windows Server 2016 64-bit + VS2017.2
    $ cmd.exe /c ver
    Microsoft Windows [Version 10.0.14393]

Repro steps:

  1. git clone https://github.com/git-for-windows/git.git D:\git\src
  2. git checkout vs/master
  3. devenv /upgrade git.sln
  4. nuget.exe restore git.sln
  5. msbuild /m /p:Configuration=Release;Platform=x86 /p:WindowsTargetPlatformVersion=10.0.15063.0 /t:Rebuild git.sln

Error info:
d:\git\src\compat/mingw.h(179): fatal error C1083: Cannot open include file: 'openssl/ssl.h': No such file or directory (s:\dd\feature\winc\src\vctools\compiler\cxxfe\sl\p1\c\p0prepro.c:1654) [D:\Git\src\libgit\libgit.vcxproj]
@dscho
Copy link
Member

dscho commented Jul 13, 2017

I think that the OpenSSL dependency only works for platform toolset v140 for now. can you give that a try?

@KarenHuang2016
Copy link
Author

@dscho, yes, we can build git sucessfully with VS2015. We moved to VS2017 now. Could you please try to support VS2017?

@dscho
Copy link
Member

dscho commented Jul 14, 2017

@KarenHuang2016 as far as I recall, VS2017 supports platform toolset v140, you just have to configure it correctly?

As to adding support for VS2017: I would love to, I simply do not have the time. Feel free, however, to help with this effort, e.g. by editing libgit/libgit.vcxproj so that it finds openssl/ssl.h. We have some conditional blocks in there that already demonstrate how to add include paths for dependencies that do not support even platform toolset v140.

@KarenHuang2016
Copy link
Author

KarenHuang2016 commented Jul 19, 2017 •
edited
Loading

@dscho, thanks for looking into this issue!

I tried to add the v140 openssl path (openssl.v140.windesktop.msvcstl.dyn.rt-dyn.x86.1.0.2.1\build\native\include) to AdditionalIncludeDirectores for libgit.vcxproj. libgit.vcxproj can be built sucessfully.
But all the test projects like test-delta failed due to some link errors:

1>------ Build started: Project: test-delta, Configuration: Debug x64 ------
1>C:\Program Files (x86)\Microsoft Visual Studio\2017\Enterprise\VC\Tools\MSVC\14.10.25017\bin\HostX86\x64\CL.exe /c /ID:\Git\src\compat\vcbuild\GEN.PKGS\libssh2.1.4.3.3\build\native../..//build/native/include/ /ID:\Git\src\compat\vcbuild\GEN.PKGS\libiconv.1.14.0.11\build\native../..//build/native/include/ /ID:\Git\src\compat\vcbuild\GEN.PKGS\expat.2.1.0.11\build\native../..//build/native/include/ /ID:\Git\src\compat\vcbuild\GEN.PKGS\curl.7.30.0.2\build\native../..//build/native/include/ /I....... /I"......\compat\vcbuild\GEN.PKGS\openssl.v140.windesktop.msvcstl.dyn.rt-dyn.x86.1.0.2.1\build\native\include" /I"......\compat\vcbuild\GEN.PKGS\zlib.v140.windesktop.msvcstl.dyn.rt-dyn.1.2.8.8\build\native\include" /I......\compat /I......\compat\poll /I......\compat\regex /I......\compat\vcbuild\GEN.DEPS\include /I......\compat\vcbuild\GEN.DEPS\include\expat /I......\compat\vcbuild\GEN.DEPS\include\zlib /I......\compat\vcbuild\include /I......\compat\win32 /I"c:\Program Files (x86)\Microsoft Visual Studio 14.0\VC\INCLUDE" /I"c:\Program Files (x86)\Windows Kits\10\Include\10.0.10240.0\ucrt" /I"c:\Program Files (x86)\Windows Kits\8.1\Include\shared" /I"c:\Program Files (x86)\Windows Kits\8.1\Include\um" /Zi /nologo /W1 /WX- /diagnostics:classic /Od /Ob1 /D HAS_EXPAT /D HAS_LIBCURL /D WIN32 /D _DEBUG /D "DEFAULT_HELP_FORMAT="html"" /D DETECT_MSYS_TTY /D HAVE_ALLOCA_H /D HAVE_STRING_H /D NATIVE_CRLF /D NDEBUG /D NOGDI /D NO_GETTEXT /D NO_INET_NTOP /D NO_INET_PTON /D NO_INTTYPES_H /D NO_IPV6 /D NO_LIBGEN_H /D NO_MEMMEM /D NO_MKDTEMP /D NO_POLL /D NO_POSIX_GOODIES /D NO_PREAD /D NO_SETENV /D NO_STRCASESTR /D NO_STRLCPY /D NO_STRTOUMAX /D NO_ST_BLOCKS_IN_STRUCT_STAT /D NO_SYMLINK_HEAD /D NO_SYS_POLL_H /D OBJECT_CREATION_MODE=1 /D "PAGER_ENV="LESS=FRX LV=-c"" /D PROTECT_NTFS_DEFAULT=1 /D RUNTIME_PREFIX /D "SHA1DC_CUSTOM_INCLUDE_SHA1_C="cache.h"" /D "SHA1DC_CUSTOM_INCLUDE_UBC_CHECK_C="git-compat-util.h"" /D "SHA1DC_CUSTOM_TRAILING_INCLUDE_SHA1_C="sha1dc_git.c"" /D "SHA1DC_CUSTOM_TRAILING_INCLUDE_SHA1_H="sha1dc_git.h"" /D SHA1DC_INIT_SAFE_HASH_DEFAULT=0 /D SHA1DC_NO_STANDARD_INCLUDES /D SHA1_DC /D "SHELL_PATH="/bin/sh"" /D "STRIP_EXTENSION=".exe"" /D UNRELIABLE_FSTAT /D USE_CURL_FOR_IMAP_SEND /D USE_WIN32_MMAP /D WIN32 /D _CONSOLE /D CRT_NONSTDC_NO_DEPRECATE /D CRT_SECURE_NO_WARNINGS /D USE_MINGW_ACCESS /Gm /EHsc /RTC1 /MDd /GS /fp:precise /Zc:wchar_t /Zc:forScope /Zc:inline /Fo"x64\Debug\" /Fd"x64\Debug\vc141.pdb" /Gd /TC /errorReport:prompt -nologo "......\common-main.c" "......\t\helper\test-delta.c"
1>test-delta.c
1>common-main.c
1>Generating Code...
1>C:\Program Files (x86)\Microsoft Visual Studio\2017\Enterprise\VC\Tools\MSVC\14.10.25017\bin\HostX86\x64\link.exe /ERRORREPORT:PROMPT /OUT:"..\test-delta.exe" /INCREMENTAL /NOLOGO advapi32.lib kernel32.lib ntdll.lib shell32.lib user32.lib wininet.lib ws2_32.lib ......\compat\vcbuild\GEN.PKGS\libiconv.1.14.0.11\build\native\lib\v110\x64\Release\dynamic\cdecl\libiconv.lib /MANIFEST:NO /DEBUG:FASTLINK /PDB:"..\test-delta.pdb" /SUBSYSTEM:CONSOLE /TLBID:1 /DYNAMICBASE /NXCOMPAT /IMPLIB:"..\test-delta.lib" /MACHINE:X64 invalidcontinue.obj "x64\Debug\common-main.obj"
1>"x64\Debug\test-delta.obj"
1>D:\Git\src\libgit.lib
1>D:\Git\src\xdiff\xdiff_lib.lib
1>libgit.lib(zlib.obj) : error LNK2019: unresolved external symbol deflate referenced in function git_deflate
1>libgit.lib(zlib.obj) : error LNK2019: unresolved external symbol deflateEnd referenced in function git_deflate_abort
1>libgit.lib(zlib.obj) : error LNK2019: unresolved external symbol inflate referenced in function git_inflate
1>libgit.lib(zlib.obj) : error LNK2019: unresolved external symbol inflateEnd referenced in function git_inflate_end
1>libgit.lib(zlib.obj) : error LNK2019: unresolved external symbol deflateBound referenced in function git_deflate_bound
1>libgit.lib(zlib.obj) : error LNK2019: unresolved external symbol deflateInit referenced in function git_deflate_init
1>libgit.lib(zlib.obj) : error LNK2019: unresolved external symbol inflateInit referenced in function git_inflate_init
1>libgit.lib(zlib.obj) : error LNK2019: unresolved external symbol deflateInit2 referenced in function do_git_deflate_init
1>libgit.lib(zlib.obj) : error LNK2019: unresolved external symbol inflateInit2 referenced in function git_inflate_init_gzip_only
1>libgit.lib(pack-check.obj) : error LNK2019: unresolved external symbol crc32 referenced in function check_pack_crc
1>libgit.lib(csum-file.obj) : error LNK2001: unresolved external symbol crc32
1>..\test-delta.exe : fatal error LNK1120: 10 unresolved externals
1>Done building project "test-delta.vcxproj" -- FAILED.

@dscho
Copy link
Member

dscho commented Aug 5, 2017

Oh my. I guess I will have to spend some time on this issue, then. Unless anybody beats me to it, I hope to get back to this by November (that's how far my current backlog looks to me).

@dscho dscho added this to the v2.14.1(2) milestone Sep 18, 2017
@dscho dscho mentioned this issue Sep 18, 2017
Merged
@dscho dscho closed this as completed in 8a8fa14 Sep 18, 2017
dscho pushed a commit that referenced this issue Sep 19, 2017
@jeffhostetler @dscho
vcxproj.pm: fix AdditionalDependencies
5e06e12 
Add .LIBs for zlib and openssl to <AdditionalDependencies>
to help linker when building with VS2017.

This closes #1234

Note: this patch still leaves a couple of TODOs:

- It should be possible to add GEN.DEPS\lib to
  <AdditionalLibraryDependencies> and then just set
  <AdditionalDependencies> to the library basenames.

- Likewise, you should be able to copy GEN.DEPS\bin\*.dll
  to the destination directory rather than using the full
  paths in the $afterTargets lines.

(This is in line with items in <AdditionalIncludeDirectories>
referencing GEN.DEPS\include.)

Signed-off-by: Jeff Hostetler <[email protected]>
Signed-off-by: Johannes Schindelin <[email protected]>
git-for-windows-ci pushed a commit that referenced this issue Sep 20, 2017
@jeffhostetler
vcxproj.pm: fix AdditionalDependencies
6f5da3a 
Add .LIBs for zlib and openssl to <AdditionalDependencies>
to help linker when building with VS2017.

This closes #1234

Note: this patch still leaves a couple of TODOs:

- It should be possible to add GEN.DEPS\lib to
  <AdditionalLibraryDependencies> and then just set
  <AdditionalDependencies> to the library basenames.

- Likewise, you should be able to copy GEN.DEPS\bin\*.dll
  to the destination directory rather than using the full
  paths in the $afterTargets lines.

(This is in line with items in <AdditionalIncludeDirectories>
referencing GEN.DEPS\include.)

Signed-off-by: Jeff Hostetler <[email protected]>
Signed-off-by: Johannes Schindelin <[email protected]>
dscho pushed a commit that referenced this issue Sep 20, 2017
@jeffhostetler @dscho
vcxproj.pm: fix AdditionalDependencies
c752630 
Add .LIBs for zlib and openssl to <AdditionalDependencies>
to help linker when building with VS2017.

This closes #1234

Note: this patch still leaves a couple of TODOs:

- It should be possible to add GEN.DEPS\lib to
  <AdditionalLibraryDependencies> and then just set
  <AdditionalDependencies> to the library basenames.

- Likewise, you should be able to copy GEN.DEPS\bin\*.dll
  to the destination directory rather than using the full
  paths in the $afterTargets lines.

(This is in line with items in <AdditionalIncludeDirectories>
referencing GEN.DEPS\include.)

Signed-off-by: Jeff Hostetler <[email protected]>
Signed-off-by: Johannes Schindelin <[email protected]>
git-for-windows-ci pushed a commit that referenced this issue Sep 21, 2017
@jeffhostetler
vcxproj.pm: fix AdditionalDependencies
349819c 
Add .LIBs for zlib and openssl to <AdditionalDependencies>
to help linker when building with VS2017.

This closes #1234

Note: this patch still leaves a couple of TODOs:

- It should be possible to add GEN.DEPS\lib to
  <AdditionalLibraryDependencies> and then just set
  <AdditionalDependencies> to the library basenames.

- Likewise, you should be able to copy GEN.DEPS\bin\*.dll
  to the destination directory rather than using the full
  paths in the $afterTargets lines.

(This is in line with items in <AdditionalIncludeDirectories>
referencing GEN.DEPS\include.)

Signed-off-by: Jeff Hostetler <[email protected]>
Signed-off-by: Johannes Schindelin <[email protected]>
git-for-windows-ci pushed a commit that referenced this issue Sep 21, 2017
@jeffhostetler
vcxproj.pm: fix AdditionalDependencies
c9ee51b 
Add .LIBs for zlib and openssl to <AdditionalDependencies>
to help linker when building with VS2017.

This closes #1234

Note: this patch still leaves a couple of TODOs:

- It should be possible to add GEN.DEPS\lib to
  <AdditionalLibraryDependencies> and then just set
  <AdditionalDependencies> to the library basenames.

- Likewise, you should be able to copy GEN.DEPS\bin\*.dll
  to the destination directory rather than using the full
  paths in the $afterTargets lines.

(This is in line with items in <AdditionalIncludeDirectories>
referencing GEN.DEPS\include.)

Signed-off-by: Jeff Hostetler <[email protected]>
Signed-off-by: Johannes Schindelin <[email protected]>
git-for-windows-ci pushed a commit that referenced this issue Sep 26, 2017
@jeffhostetler
vcxproj.pm: fix AdditionalDependencies
f1a2fc2 
Add .LIBs for zlib and openssl to <AdditionalDependencies>
to help linker when building with VS2017.

This closes #1234

Note: this patch still leaves a couple of TODOs:

- It should be possible to add GEN.DEPS\lib to
  <AdditionalLibraryDependencies> and then just set
  <AdditionalDependencies> to the library basenames.

- Likewise, you should be able to copy GEN.DEPS\bin\*.dll
  to the destination directory rather than using the full
  paths in the $afterTargets lines.

(This is in line with items in <AdditionalIncludeDirectories>
referencing GEN.DEPS\include.)

Signed-off-by: Jeff Hostetler <[email protected]>
Signed-off-by: Johannes Schindelin <[email protected]>
git-for-windows-ci pushed a commit that referenced this issue Sep 26, 2017
@jeffhostetler
vcxproj.pm: fix AdditionalDependencies
eddf810 
Add .LIBs for zlib and openssl to <AdditionalDependencies>
to help linker when building with VS2017.

This closes #1234

Note: this patch still leaves a couple of TODOs:

- It should be possible to add GEN.DEPS\lib to
  <AdditionalLibraryDependencies> and then just set
  <AdditionalDependencies> to the library basenames.

- Likewise, you should be able to copy GEN.DEPS\bin\*.dll
  to the destination directory rather than using the full
  paths in the $afterTargets lines.

(This is in line with items in <AdditionalIncludeDirectories>
referencing GEN.DEPS\include.)

Signed-off-by: Jeff Hostetler <[email protected]>
Signed-off-by: Johannes Schindelin <[email protected]>
dscho pushed a commit that referenced this issue Sep 26, 2017
@jeffhostetler @dscho
vcxproj.pm: fix AdditionalDependencies
03a451a 
Add .LIBs for zlib and openssl to <AdditionalDependencies>
to help linker when building with VS2017.

This closes #1234

Note: this patch still leaves a couple of TODOs:

- It should be possible to add GEN.DEPS\lib to
  <AdditionalLibraryDependencies> and then just set
  <AdditionalDependencies> to the library basenames.

- Likewise, you should be able to copy GEN.DEPS\bin\*.dll
  to the destination directory rather than using the full
  paths in the $afterTargets lines.

(This is in line with items in <AdditionalIncludeDirectories>
referencing GEN.DEPS\include.)

Signed-off-by: Jeff Hostetler <[email protected]>
Signed-off-by: Johannes Schindelin <[email protected]>
dscho pushed a commit that referenced this issue Oct 17, 2017
@jeffhostetler @dscho
vcxproj.pm: fix AdditionalDependencies
4e91940 
Add .LIBs for zlib and openssl to <AdditionalDependencies>
to help linker when building with VS2017.

This closes #1234

Note: this patch still leaves a couple of TODOs:

- It should be possible to add GEN.DEPS\lib to
  <AdditionalLibraryDependencies> and then just set
  <AdditionalDependencies> to the library basenames.

- Likewise, you should be able to copy GEN.DEPS\bin\*.dll
  to the destination directory rather than using the full
  paths in the $afterTargets lines.

(This is in line with items in <AdditionalIncludeDirectories>
referencing GEN.DEPS\include.)

Signed-off-by: Jeff Hostetler <[email protected]>
Signed-off-by: Johannes Schindelin <[email protected]>
dscho pushed a commit that referenced this issue Oct 19, 2017
@jeffhostetler @dscho
vcxproj.pm: fix AdditionalDependencies
31c14c1 
Add .LIBs for zlib and openssl to <AdditionalDependencies>
to help linker when building with VS2017.

This closes #1234

Note: this patch still leaves a couple of TODOs:

- It should be possible to add GEN.DEPS\lib to
  <AdditionalLibraryDependencies> and then just set
  <AdditionalDependencies> to the library basenames.

- Likewise, you should be able to copy GEN.DEPS\bin\*.dll
  to the destination directory rather than using the full
  paths in the $afterTargets lines.

(This is in line with items in <AdditionalIncludeDirectories>
referencing GEN.DEPS\include.)

Signed-off-by: Jeff Hostetler <[email protected]>
Signed-off-by: Johannes Schindelin <[email protected]>
dscho pushed a commit that referenced this issue Oct 19, 2017
@jeffhostetler @dscho
vcxproj.pm: fix AdditionalDependencies
9035771 
Add .LIBs for zlib and openssl to <AdditionalDependencies>
to help linker when building with VS2017.

This closes #1234

Note: this patch still leaves a couple of TODOs:

- It should be possible to add GEN.DEPS\lib to
  <AdditionalLibraryDependencies> and then just set
  <AdditionalDependencies> to the library basenames.

- Likewise, you should be able to copy GEN.DEPS\bin\*.dll
  to the destination directory rather than using the full
  paths in the $afterTargets lines.

(This is in line with items in <AdditionalIncludeDirectories>
referencing GEN.DEPS\include.)

Signed-off-by: Jeff Hostetler <[email protected]>
Signed-off-by: Johannes Schindelin <[email protected]>
dscho pushed a commit that referenced this issue Oct 19, 2017
@jeffhostetler @dscho
vcxproj.pm: fix AdditionalDependencies
3872420 
Add .LIBs for zlib and openssl to <AdditionalDependencies>
to help linker when building with VS2017.

This closes #1234

Note: this patch still leaves a couple of TODOs:

- It should be possible to add GEN.DEPS\lib to
  <AdditionalLibraryDependencies> and then just set
  <AdditionalDependencies> to the library basenames.

- Likewise, you should be able to copy GEN.DEPS\bin\*.dll
  to the destination directory rather than using the full
  paths in the $afterTargets lines.

(This is in line with items in <AdditionalIncludeDirectories>
referencing GEN.DEPS\include.)

Signed-off-by: Jeff Hostetler <[email protected]>
Signed-off-by: Johannes Schindelin <[email protected]>
dscho pushed a commit that referenced this issue Oct 19, 2017
@jeffhostetler @dscho
vcxproj.pm: fix AdditionalDependencies
6936b8b 
Add .LIBs for zlib and openssl to <AdditionalDependencies>
to help linker when building with VS2017.

This closes #1234

Note: this patch still leaves a couple of TODOs:

- It should be possible to add GEN.DEPS\lib to
  <AdditionalLibraryDependencies> and then just set
  <AdditionalDependencies> to the library basenames.

- Likewise, you should be able to copy GEN.DEPS\bin\*.dll
  to the destination directory rather than using the full
  paths in the $afterTargets lines.

(This is in line with items in <AdditionalIncludeDirectories>
referencing GEN.DEPS\include.)

Signed-off-by: Jeff Hostetler <[email protected]>
Signed-off-by: Johannes Schindelin <[email protected]>
dscho pushed a commit that referenced this issue Oct 19, 2017
@jeffhostetler @dscho
vcxproj.pm: fix AdditionalDependencies
09dc688 
Add .LIBs for zlib and openssl to <AdditionalDependencies>
to help linker when building with VS2017.

This closes #1234

Note: this patch still leaves a couple of TODOs:

- It should be possible to add GEN.DEPS\lib to
  <AdditionalLibraryDependencies> and then just set
  <AdditionalDependencies> to the library basenames.

- Likewise, you should be able to copy GEN.DEPS\bin\*.dll
  to the destination directory rather than using the full
  paths in the $afterTargets lines.

(This is in line with items in <AdditionalIncludeDirectories>
referencing GEN.DEPS\include.)

Signed-off-by: Jeff Hostetler <[email protected]>
Signed-off-by: Johannes Schindelin <[email protected]>
git-for-windows-ci pushed a commit that referenced this issue Oct 20, 2017
@jeffhostetler
vcxproj.pm: fix AdditionalDependencies
3566d09 
Add .LIBs for zlib and openssl to <AdditionalDependencies>
to help linker when building with VS2017.

This closes #1234

Note: this patch still leaves a couple of TODOs:

- It should be possible to add GEN.DEPS\lib to
  <AdditionalLibraryDependencies> and then just set
  <AdditionalDependencies> to the library basenames.

- Likewise, you should be able to copy GEN.DEPS\bin\*.dll
  to the destination directory rather than using the full
  paths in the $afterTargets lines.

(This is in line with items in <AdditionalIncludeDirectories>
referencing GEN.DEPS\include.)

Signed-off-by: Jeff Hostetler <[email protected]>
Signed-off-by: Johannes Schindelin <[email protected]>
git-for-windows-ci pushed a commit that referenced this issue Oct 20, 2017
@jeffhostetler
vcxproj.pm: fix AdditionalDependencies
8457101 
Add .LIBs for zlib and openssl to <AdditionalDependencies>
to help linker when building with VS2017.

This closes #1234

Note: this patch still leaves a couple of TODOs:

- It should be possible to add GEN.DEPS\lib to
  <AdditionalLibraryDependencies> and then just set
  <AdditionalDependencies> to the library basenames.

- Likewise, you should be able to copy GEN.DEPS\bin\*.dll
  to the destination directory rather than using the full
  paths in the $afterTargets lines.

(This is in line with items in <AdditionalIncludeDirectories>
referencing GEN.DEPS\include.)

Signed-off-by: Jeff Hostetler <[email protected]>
Signed-off-by: Johannes Schindelin <[email protected]>
dscho pushed a commit that referenced this issue Aug 23, 2018
@jeffhostetler @dscho
vcxproj.pm: fix AdditionalDependencies
472a206 
Add .LIBs for zlib and openssl to <AdditionalDependencies>
to help linker when building with VS2017.

This closes #1234

Note: this patch still leaves a couple of TODOs:

- It should be possible to add GEN.DEPS\lib to
  <AdditionalLibraryDependencies> and then just set
  <AdditionalDependencies> to the library basenames.

- Likewise, you should be able to copy GEN.DEPS\bin\*.dll
  to the destination directory rather than using the full
  paths in the $afterTargets lines.

(This is in line with items in <AdditionalIncludeDirectories>
referencing GEN.DEPS\include.)

Signed-off-by: Jeff Hostetler <[email protected]>
Signed-off-by: Johannes Schindelin <[email protected]>
jamill pushed a commit to jamill/git that referenced this issue Aug 28, 2018
@jeffhostetler @jamill
vcxproj.pm: fix AdditionalDependencies
96f40ee 
Add .LIBs for zlib and openssl to <AdditionalDependencies>
to help linker when building with VS2017.

This closes git-for-windows#1234

Note: this patch still leaves a couple of TODOs:

- It should be possible to add GEN.DEPS\lib to
  <AdditionalLibraryDependencies> and then just set
  <AdditionalDependencies> to the library basenames.

- Likewise, you should be able to copy GEN.DEPS\bin\*.dll
  to the destination directory rather than using the full
  paths in the $afterTargets lines.

(This is in line with items in <AdditionalIncludeDirectories>
referencing GEN.DEPS\include.)

Signed-off-by: Jeff Hostetler <[email protected]>
Signed-off-by: Johannes Schindelin <[email protected]>
jamill pushed a commit to jamill/git that referenced this issue Sep 5, 2018
@jeffhostetler @jamill
vcxproj.pm: fix AdditionalDependencies
f11d0b1 
Add .LIBs for zlib and openssl to <AdditionalDependencies>
to help linker when building with VS2017.

This closes git-for-windows#1234

Note: this patch still leaves a couple of TODOs:

- It should be possible to add GEN.DEPS\lib to
  <AdditionalLibraryDependencies> and then just set
  <AdditionalDependencies> to the library basenames.

- Likewise, you should be able to copy GEN.DEPS\bin\*.dll
  to the destination directory rather than using the full
  paths in the $afterTargets lines.

(This is in line with items in <AdditionalIncludeDirectories>
referencing GEN.DEPS\include.)

Signed-off-by: Jeff Hostetler <[email protected]>
Signed-off-by: Johannes Schindelin <[email protected]>
git-for-windows-ci pushed a commit that referenced this issue Sep 10, 2018
@jeffhostetler
vcxproj.pm: fix AdditionalDependencies
86d1ac1 
Add .LIBs for zlib and openssl to <AdditionalDependencies>
to help linker when building with VS2017.

This closes #1234

Note: this patch still leaves a couple of TODOs:

- It should be possible to add GEN.DEPS\lib to
  <AdditionalLibraryDependencies> and then just set
  <AdditionalDependencies> to the library basenames.

- Likewise, you should be able to copy GEN.DEPS\bin\*.dll
  to the destination directory rather than using the full
  paths in the $afterTargets lines.

(This is in line with items in <AdditionalIncludeDirectories>
referencing GEN.DEPS\include.)

Signed-off-by: Jeff Hostetler <[email protected]>
Signed-off-by: Johannes Schindelin <[email protected]>
jamill pushed a commit to jamill/git that referenced this issue Sep 11, 2018
@jeffhostetler @jamill
vcxproj.pm: fix AdditionalDependencies
32cc42a 
Add .LIBs for zlib and openssl to <AdditionalDependencies>
to help linker when building with VS2017.

This closes git-for-windows#1234

Note: this patch still leaves a couple of TODOs:

- It should be possible to add GEN.DEPS\lib to
  <AdditionalLibraryDependencies> and then just set
  <AdditionalDependencies> to the library basenames.

- Likewise, you should be able to copy GEN.DEPS\bin\*.dll
  to the destination directory rather than using the full
  paths in the $afterTargets lines.

(This is in line with items in <AdditionalIncludeDirectories>
referencing GEN.DEPS\include.)

Signed-off-by: Jeff Hostetler <[email protected]>
Signed-off-by: Johannes Schindelin <[email protected]>
git-for-windows-ci pushed a commit that referenced this issue Sep 24, 2018
@jeffhostetler
vcxproj.pm: fix AdditionalDependencies
eb3a73a 
Add .LIBs for zlib and openssl to <AdditionalDependencies>
to help linker when building with VS2017.

This closes #1234

Note: this patch still leaves a couple of TODOs:

- It should be possible to add GEN.DEPS\lib to
  <AdditionalLibraryDependencies> and then just set
  <AdditionalDependencies> to the library basenames.

- Likewise, you should be able to copy GEN.DEPS\bin\*.dll
  to the destination directory rather than using the full
  paths in the $afterTargets lines.

(This is in line with items in <AdditionalIncludeDirectories>
referencing GEN.DEPS\include.)

Signed-off-by: Jeff Hostetler <[email protected]>
Signed-off-by: Johannes Schindelin <[email protected]>
dscho pushed a commit that referenced this issue Oct 10, 2018
@jeffhostetler @dscho
vcxproj.pm: fix AdditionalDependencies
b4bda8d 
Add .LIBs for zlib and openssl to <AdditionalDependencies>
to help linker when building with VS2017.

This closes #1234

Note: this patch still leaves a couple of TODOs:

- It should be possible to add GEN.DEPS\lib to
  <AdditionalLibraryDependencies> and then just set
  <AdditionalDependencies> to the library basenames.

- Likewise, you should be able to copy GEN.DEPS\bin\*.dll
  to the destination directory rather than using the full
  paths in the $afterTargets lines.

(This is in line with items in <AdditionalIncludeDirectories>
referencing GEN.DEPS\include.)

Signed-off-by: Jeff Hostetler <[email protected]>
Signed-off-by: Johannes Schindelin <[email protected]>
dscho pushed a commit to dscho/git that referenced this issue Oct 12, 2018
@jeffhostetler @dscho
vcxproj.pm: fix AdditionalDependencies
4f844c2 
Add .LIBs for zlib and openssl to <AdditionalDependencies>
to help linker when building with VS2017.

This closes git-for-windows#1234

Note: this patch still leaves a couple of TODOs:

- It should be possible to add GEN.DEPS\lib to
  <AdditionalLibraryDependencies> and then just set
  <AdditionalDependencies> to the library basenames.

- Likewise, you should be able to copy GEN.DEPS\bin\*.dll
  to the destination directory rather than using the full
  paths in the $afterTargets lines.

(This is in line with items in <AdditionalIncludeDirectories>
referencing GEN.DEPS\include.)

Signed-off-by: Jeff Hostetler <[email protected]>
Signed-off-by: Johannes Schindelin <[email protected]>
dscho pushed a commit that referenced this issue Oct 12, 2018
@jeffhostetler @dscho
vcxproj.pm: fix AdditionalDependencies
2665c48 
Add .LIBs for zlib and openssl to <AdditionalDependencies>
to help linker when building with VS2017.

This closes #1234

Note: this patch still leaves a couple of TODOs:

- It should be possible to add GEN.DEPS\lib to
  <AdditionalLibraryDependencies> and then just set
  <AdditionalDependencies> to the library basenames.

- Likewise, you should be able to copy GEN.DEPS\bin\*.dll
  to the destination directory rather than using the full
  paths in the $afterTargets lines.

(This is in line with items in <AdditionalIncludeDirectories>
referencing GEN.DEPS\include.)

Signed-off-by: Jeff Hostetler <[email protected]>
Signed-off-by: Johannes Schindelin <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug git
Projects
None yet
Milestone
v2.14.2
Development

No branches or pull requests
2 participants
@dscho @KarenHuang2016