Skip to content

Typo in installer #265

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
msg7086 opened this issue Aug 9, 2015 · 7 comments
Closed

Typo in installer #265

msg7086 opened this issue Aug 9, 2015 · 7 comments

Comments

@msg7086
Copy link

msg7086 commented Aug 9, 2015

I noticed the word sports when configuring the terminal emulator.

I suppose this should be supports.

@linquize
Copy link

linquize commented Aug 9, 2015

@msg7086 No. The word sport can be used as a verb. I think here it means display, wear ...

@dscho
Copy link
Member

dscho commented Aug 9, 2015

Yep, not a typo. @msg7086 please feel free to provide more context next time, I had to look quite hard to find what you were talking about. For example, it would have helped enormously to mention the complete message:

Use MinTTY (the default terminal of MSys2)

Git Bash will use MinTTY as terminal emulator, which sports a resizable window,
non-rectangular selections and a Unicode font. Windows console programs (such as
an interactive Python console) must be launched via `winpty` to work in MinTTY.

@ctahok
Copy link

ctahok commented Dec 12, 2019

@PhilipOakley
Copy link

PhilipOakley commented Dec 12, 2019 via email

@ctahok
Copy link

ctahok commented Dec 12, 2019 via email

@dscho
Copy link
Member

dscho commented Dec 12, 2019

If the issue was raised 3 times (these are who noticed it) that means it is troublesome.

Maybe. If it has been raised 3 times. When comparing to what I estimated conservatively to be 3 million regular users (v2.23 was downloaded over 6 million times), it is maybe not that troublesome.

It is up to you to re-phrase it or keep it.

@ctahok that is an incorrect conclusion. This is open source, not a product for which you paid somebody else to support you. It is up to you to open a PR with a proposed fix, and then to work with the reviewers until it is acceptable to merge it.

I mean, you are using a piece of software that according to https://www.openhub.net/p/git-for-windows/estimated_cost has an estimated cost of over 8 million dollars, and I cannot find any record of you contributing back to the project, or for that matter, even show some appreciation.

To the contrary, I see that you throw about one- or two-line comments and then expect others to do as you say.

Not only is that contrary to the conduct we want to see in this project. If you really wanted to see this issue fixed, it also would appear to be a very odd and counter-productive way to go about it.

@ctahok
Copy link

ctahok commented Dec 13, 2019 via email

jeffhostetler pushed a commit to jeffhostetler/git that referenced this issue May 13, 2020
…NTLM

Fix NTLM support in gvfs-helper.

NTLM is handled magically by libcurl when we CURLAUTH_ANY is enabled AND
we passed empty username/password. This lets it negotiate with the server and
choose the best authentication scheme.
jeffhostetler pushed a commit to jeffhostetler/git that referenced this issue Jun 3, 2020
…NTLM

Fix NTLM support in gvfs-helper.

NTLM is handled magically by libcurl when we CURLAUTH_ANY is enabled AND
we passed empty username/password. This lets it negotiate with the server and
choose the best authentication scheme.
jeffhostetler pushed a commit to jeffhostetler/git that referenced this issue May 14, 2021
…NTLM

Fix NTLM support in gvfs-helper.

NTLM is handled magically by libcurl when we CURLAUTH_ANY is enabled AND
we passed empty username/password. This lets it negotiate with the server and
choose the best authentication scheme.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants