ARM64: cannot read/write system gitconfig

[dennisameling]

• I was not able to find an open or closed issue matching what I'm seeing

This is not an urgent issue, since ARM64 Windows is only in the testing phase right now, and no official builds have been published yet.

Setup

• Which version of Git for Windows are you using? Is it 32-bit or 64-bit?

ARM64 Windows test build: https://github.com/dscho/git/actions/runs/597692856

$ git --version --build-options
git version 2.30.1.GIT
cpu: AMD64
no commit associated with this build
sizeof-long: 4
sizeof-size_t: 8
shell-path: /bin/sh
feature: fsmonitor--daemon

• Which version of Windows are you running? Vista, 7, 8, 10? Is it 32-bit or 64-bit?

$ cmd.exe /c ver

Windows 10 ARM64
Microsoft Windows [Version 10.0.19042.804]

• What options did you set as part of the installation? Or did you choose the
  defaults?

# One of the following:
> type "C:\Program Files\Git\etc\install-options.txt"
> type "C:\Program Files (x86)\Git\etc\install-options.txt"
> type "%USERPROFILE%\AppData\Local\Programs\Git\etc\install-options.txt"
$ cat /etc/install-options.txt

Editor Option: VisualStudioCode
Custom Editor Path:
Default Branch Option: main
Path Option: Cmd
SSH Option: OpenSSH
Tortoise Option: false
CURL Option: WinSSL
CRLF Option: CRLFAlways
Bash Terminal Option: MinTTY
Git Pull Behavior Option: Merge
Use Credential Manager: Core
Performance Tweaks FSCache: Enabled
Enable Symlinks: Enabled
Enable Pseudo Console Support: Disabled

• Any other interesting things about your environment that might be related
  to the issue you're seeing?

ARM64 😉

Details

• Which terminal/shell are you running Git from? e.g Bash/CMD/PowerShell/other

Git Bash

• What commands did you run to trigger this issue? If you can provide a
  Minimal, Complete, and Verifiable example
  this will help us understand the issue.

denni@DESKTOP-8HTP3NV ARM64 /c/repos
$ git config --list

denni@DESKTOP-8HTP3NV ARM64 /c/repos
$ git config --system http.sslbackend schannel
error: could not lock config file C:/Program Files (x86)/Git/arm64/etc/gitconfig: No such file or directory

• What did you expect to occur after running these commands?

git config --list should show the Git configuration.

• What actually happened instead?

git config --list doesn't return anything. However, after I copied /etc/gitconfig to /arm64/etc/gitconfig, git config --list started showing the correct output:

denni@DESKTOP-8HTP3NV ARM64 /c/repos
$ git config --list
pack.packsizelimit=2g
diff.astextplain.textconv=astextplain
filter.lfs.clean=git-lfs clean -- %f
filter.lfs.smudge=git-lfs smudge -- %f
filter.lfs.process=git-lfs filter-process
filter.lfs.required=true
http.sslbackend=openssl
http.sslcainfo=C:/Program Files (x86)/Git/mingw32/ssl/certs/ca-bundle.crt
core.autocrlf=true
core.fscache=true
core.symlinks=true
pull.rebase=false
credential.helper=manager-core
credential.https://dev.azure.com.usehttppath=true
init.defaultbranch=main

... so the ARM64 Git for Windows (Bash at least) looks for gitconfig in the wrong folder.

• If the problem was occurring with a specific repository, can you provide the
  URL to that repository to help us with testing?

N/A

[dscho]

This is intentional. The system config is located within C:\Program Files*, and therefore only writable if you run Git in elevated mode (you can, for example, hit the Windows key, then type "Git Bash" and then hit Ctrl+Shift+Enter).

[dscho]

Oh, and please note that it is not really intended for users to write stuff into the system config, that config really is "owned" by Git for Windows. Use git config --global (i.e. $HOME/.gitconfig) to configure things instead.

[dennisameling]

That's my bad, sorry, but git config --global doesn't work either:

$ git config --global
C:/Program Files (x86)/Git/arm64/bin/git.exe: error while loading shared libraries: ?: cannot open shared object file: No such file or directory

maybe that's why --list doesn't return anything as well! Windows logs refer to msvcrt.dll - does this mean we'll need to link Git ARM64 statically instead? Happy to close this issue and create a new one specifically for this issue if that helps. Currently, running anything git related from cmd just crashes... Something must have changed recently that broke this 😞

I'm working with the binaries mentioned in #3053 (comment) by the way!

Naam van toepassing met fout: git.exe, versie: 2.30.0.2, tijdstempel: 0x60366296
Naam van module met fout: msvcrt.dll, versie: 7.0.19041.789, tijdstempel: 0xc68c05ae
Uitzonderingscode: 0xc0000005
Foutmarge: 0x000d7dd8
Id van proces met fout: 0x510c
Starttijd van toepassing met fout: 0x01d70faef14328b2
Pad naar toepassing met fout: C:\Program Files (x86)\Git\cmd\git.exe
Pad naar module met fout: C:\WINDOWS\System32\msvcrt.dll
Rapport-id: a47f5bcf-a83d-4aa3-b19f-1c6d9d7478ae
Volledige pakketnaam met fout: 
Relatieve toepassings-id van pakket met fout: 

[dennisameling]

Bingo: zlib1.dll and iconv-2.dll are missing:

[dennisameling]

The DLLs are included in the portable-arm64 artifacts:

But not in the installer apparently:

Will dive deeper into this tomorrow - think we're not correctly including the DLLs in the installer. Which is weird, because I think that worked before...

[dennisameling]

Got the issue with missing DLLs fixed by working with a more recent build, sorry for the confusion.

The issue with the Git config is still present though. Please consider these differences:

x64 Windows machine with 32-bit Git for Windows (used Windows Sandbox to ensure clean environment):

C:\Users\WDAGUtilityAccount>git config --list --global
fatal: unable to read config file 'C:/Users/WDAGUtilityAccount/.gitconfig': No such file or directory

C:\Users\WDAGUtilityAccount>git config --list --system
pack.packsizelimit=2g
diff.astextplain.textconv=astextplain
filter.lfs.clean=git-lfs clean -- %f
filter.lfs.smudge=git-lfs smudge -- %f
filter.lfs.process=git-lfs filter-process
filter.lfs.required=true
http.sslbackend=openssl
http.sslcainfo=C:/Program Files (x86)/Git/mingw32/ssl/certs/ca-bundle.crt
core.autocrlf=true
core.fscache=true
core.symlinks=false
core.editor=nano.exe
pull.rebase=false
credential.helper=manager-core
credential.https://dev.azure.com.usehttppath=true
init.defaultbranch=main

ARM64 Windows machine with ARM64 Git for Windows installed (build: https://github.com/dscho/git/actions/runs/597692856)

denni@DESKTOP-8HTP3NV ARM64 /
$ git config --global --list
core.editor="C:\Users\denni\AppData\Local\Programs\Microsoft VS Code\Code.exe" --wait

denni@DESKTOP-8HTP3NV ARM64 /
$ git config --system --list
fatal: unable to read config file 'C:/Program Files (x86)/Git/arm64/etc/gitconfig': No such file or directory

This leads to a plethora of problems, like:

denni@DESKTOP-8HTP3NV ARM64 /
$ git clone https://github.com/dennisameling/demo-repo /c/repos/demo-repo
Cloning into 'C:/repos/demo-repo'...
fatal: unable to access 'https://github.com/dennisameling/demo-repo/': SSL certificate problem: unable to get local issuer certificate

So we need to change something in a way so that Git looks at C:/Program Files (x86)/Git/etc/gitconfig instead of C:/Program Files (x86)/Git/arm64/etc/gitconfig. Could it be that our PATH for ARM64 (or something similar) is incorrect in the git-wrapper, @dscho? What do you think?

[dscho]

C:\Users\WDAGUtilityAccount>git config --list --global
fatal: unable to read config file 'C:/Users/WDAGUtilityAccount/.gitconfig': No such file or directory

That looks correct. If there is no ~/.gitconfig, that command will fail, while git config --list won't.

denni@DESKTOP-8HTP3NV ARM64 /
$ git config --system --list
fatal: unable to read config file 'C:/Program Files (x86)/Git/arm64/etc/gitconfig': No such file or directory

That does not look correct. I think this because the CMake-based build is missing this:

git/config.mak.uname

Lines 436 to 440 in c177856

	ifeq (/mingw64,$(subst 32,64,$(prefix)))
	# Move system config into top-level /etc/
	ETC_GITCONFIG = ../etc/gitconfig
	ETC_GITATTRIBUTES = ../etc/gitattributes
	endif

This will most likely have to be implemented in one form or another here:

git/contrib/buildsystems/CMakeLists.txt

Lines 207 to 208 in c177856

	ETC_GITATTRIBUTES="etc/gitattributes"
	ETC_GITCONFIG="etc/gitconfig"

[dennisameling]

Alright, got that to work, curious to hear what you think of my approach: #3078