The 64bit version installer installed into C:\Program Files (x86)\Git

[lygstate]

The right place should be C:\Program Files\Git

[sschuberth]

There is no 64-bit version of the Git for Windows installer. The only installer we have is for 32-bit, even on 64-bit Windows.

[dscho]

Actually, there is a self-extracting PortableGit for 64-bit Windows: https://github.com/git-for-windows/git/releases/download/v2.3.4.windows.2/PortableGit-64-bit-2.3.4-dev-preview.7z.exe

@lygstate did you install the development environment via the net installer yet? If so, please check out the build-extra repository:

cd /usr/src/build-extra
git fetch
git checkout master

You should find the script to generate both 64-bit and 32-bit portable releases in portable/release.sh. Could you have a look at line 97 and at lines 15--26? I imagine that another variable needs to be set, depending on the architecture and used in line 97.

[sschuberth]

@dscho As you can see from the installation path mentioned by the OP, this issue was filed against the Inno Setup / MSYS1-based installer. As there is no issue in terms of 64-bit with that installer I think this issue should stay closed.

Please do not hook this issue for promoting the newly created MSY2-based portable setup.

[dscho]

When running the PortableGit-*.7z.exe, it suggests the directory C:\Program Files\Git as destination (or at least should do so, see https://github.com/git-for-windows/build-extra/blob/143a81c4741a1b539dafcb274e3bdca2b04f6c92/portable/release.sh#L97).

[sschuberth]

it suggests the directory C:\Program Files\Git as destination

Indeed. So MSYS2-PortableGit never uses C:\Program Files (x86), but as that's mentioned in PR's title, the OP cannot have referred to MSYS2-PortableGit.

More importantly, MSYS2-PortableGit should suggest C:\Program Files (x86) if it's the 32-bit version and we're installing on a 64-bit OS.

[kusma]

It still can refer to MSYS2-PortableGit, because if the installer is 32-bit, it'll be run under WoW, mapping "C:\Program Files\Git" to "C:\Program Files (x86)\Git"...

[dscho]

git-for-windows/build-extra@12e698f

[sschuberth]

Hmm, does that commit really do what it should? For example, the 32-bit portable installer should install to "C:\Program Files (x86)" on a 64-bit Windows by default. But in a 32-bit MSYS2 environment, uname -m returns i686 even if Windows is 64-bit. So PROGRAMFILESENV is set to PROGRAMFILES, which in turn is set to C:\Program Files instead of the expected C:\Program Files (x86), or?