Skip to content

Conversation

jeffhostetler
Copy link

Completely convert the pathname expoted in the %msvc_bin_dir_msys%
variable to MSYS format with forward slashes rather than a mixture
of forward and back slashes.

This solves an obscure problem observed by some developers:

[...]
http-push.c
    CC remote-curl.o
remote-curl.c
    * new script parameters
    GEN git-instaweb
sed: -e expression #7, char 155: invalid reference \2 on `s' command's RHS
make: *** [Makefile:2023: git-instaweb] Error 1

Signed-off-by: Jeff Hostetler [email protected]

Completely convert the pathname expoted in the %msvc_bin_dir_msys%
variable to MSYS format with forward slashes rather than a mixture
of forward and back slashes.

This solves an obscure problem observed by some developers:

    [...]
    http-push.c
        CC remote-curl.o
    remote-curl.c
        * new script parameters
        GEN git-instaweb
    sed: -e expression #7, char 155: invalid reference \2 on `s' command's RHS
    make: *** [Makefile:2023: git-instaweb] Error 1

Signed-off-by: Jeff Hostetler <[email protected]>
@jeffhostetler jeffhostetler merged commit 69eaca2 into git-for-windows:master Jul 25, 2018
dscho pushed a commit that referenced this pull request Aug 22, 2018
find_vs_env.bat: Fix bin dir path used by msys
dscho pushed a commit to dscho/git that referenced this pull request Aug 22, 2018
…in-dir

find_vs_env.bat: Fix bin dir path used by msys
dscho pushed a commit that referenced this pull request Aug 23, 2018
find_vs_env.bat: Fix bin dir path used by msys
dscho pushed a commit that referenced this pull request Aug 23, 2018
find_vs_env.bat: Fix bin dir path used by msys
dscho pushed a commit that referenced this pull request Aug 23, 2018
find_vs_env.bat: Fix bin dir path used by msys
jamill pushed a commit to jamill/git that referenced this pull request Aug 28, 2018
…in-dir

find_vs_env.bat: Fix bin dir path used by msys
jamill pushed a commit to jamill/git that referenced this pull request Sep 5, 2018
…in-dir

find_vs_env.bat: Fix bin dir path used by msys
git-for-windows-ci pushed a commit that referenced this pull request Sep 10, 2018
find_vs_env.bat: Fix bin dir path used by msys
jamill pushed a commit to jamill/git that referenced this pull request Sep 11, 2018
…in-dir

find_vs_env.bat: Fix bin dir path used by msys
git-for-windows-ci pushed a commit that referenced this pull request Sep 24, 2018
find_vs_env.bat: Fix bin dir path used by msys
dscho pushed a commit that referenced this pull request Oct 10, 2018
find_vs_env.bat: Fix bin dir path used by msys
@jeffhostetler jeffhostetler deleted the gfw-msvc-bin-dir branch July 1, 2019 18:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants