Add rfc to remove an TODO: that seems to be referencing the wrong struct field commit.c:360

[lowspeedburt]

Thanks for taking the time to contribute to Git!

Those seeking to contribute to the Git for Windows fork should see
http://gitforwindows.org/#contribute on how to contribute Windows specific enhancements.

If your contribution is for the core Git functions and documentation
please be aware that the Git community does not use the github.com issues
or pull request mechanism for their contributions.

Instead, we use the Git mailing list ([email protected]) for code and
documenatation submissions, code reviews, and bug reports. The
mailing list is plain text only (anything with HTML is sent directly
to the spam folder).

Nevertheless, you can use submitGit to conveniently send your Pull
Requests commits to our mailing list.

Please read the "guidelines for contributing" linked above!

[lowspeedburt]

Was doing some digging within the code, and came across this. @dscho

[dscho]

A good initial version!

I left a couple of comments trying to help improve it to the point where we can offer it up on the Git mailing list.

[lowspeedburt]

hey @dscho went ahead, and made the small change. Have been behind on some project work, but wanted to make sure that I had this checked in.

Would I just leave this here, or send this to the mailing list?

-Al

[dscho]

Would I just leave this here, or send this to the mailing list?

After renaming the commit message prefix from "TODO doc:" to "doc:" please do send this to the mailing list, it is ready!

[dscho]

@skinnyal how about it?

[lowspeedburt]

Hey @dscho I'll work on this right now. Sorry about the delay school, and things got hectic.

[dscho]

@skinnyal could you do a git rebase -i on top of upstream's master, squashing all the iterative changes into a single commit/patch?

[lowspeedburt]

@dscho I went ahead, and rebased. I think I did it in the correct order. I'm unsure if the merging to my local remote should be the latest entry in git log , or no.

[dscho]

I'm unsure if the merging to my local remote should be the latest entry in git log , or no.

Ideally, there should not even be a merge commit in your branch. There is no way to "export" a merge commit via format-patch. It cannot be represented as a patch.

[dscho]

Ideally, there should not even be a merge commit in your branch.

To clarify what I mean: this is what I am seeing in the Commits tab of this PR:

• Add rfc to remove an TODO: that seems to be referencing the wrong str…
• TODO doc: remove unneeded TODO for release_commit_memory
• doc: remove unneeded TODO for release_commit_memory
• Merge branch 'skinnyal/microprojects' of https://github.com/skinnyal/git
• doc: remove unneeded TODO for release_commit_memory
• Merge branch 'skinnyal/microprojects' of https://github.com/skinnyal/git

What I expected to see would look more like

• doc: remove unneeded TODO for release_commit_memory

This could be achieved by running these commands:

git fetch https://github.com/git/git master
git rebase -i FETCH_HEAD

and then changing each pick except the very first one to squash. Then save the file and close the editor (or editor tab), and when the editor comes back up, edit the commit message appropriately (most likely just keeping the last commit message).

[lowspeedburt]

Ah, Okay. I think it should be fixed now @dscho .

[dscho]

I think it should be fixed now

Yep! Thanks!

[lowspeedburt]

No problemo! Thanks for following up with this. Sent it off to the mailing list!

[dscho]

For lurkers: the mail is here: https://public-inbox.org/git/CACsJy8D_gTKWXogPDNW7NQk_a0ChBu28HfGu388hFn3-by_cRw@mail.gmail.com/T/#t