Rebase: Run post-checkout hook on checkout #1992
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
orgads
force-pushed
the
rebase-post-checkout-hook
branch
from
c34ad5a to
b532ab4
Compare
|
I can't currently post the patch to the mailing list, and I doubt this is the right way to deal with the GIT_DIR bug (assuming it's a bug at all). Let's start the review here, and if you accept it, I'll post it upstream. |
dscho
requested changes
Dec 20, 2018
* Replace multiple clones and commits by test_commits. * Replace 3 invocations of awk by read. Signed-off-by: Orgad Shaneh <[email protected]>
Signed-off-by: Orgad Shaneh <[email protected]>
orgads
force-pushed
the
rebase-post-checkout-hook
branch
from
b532ab4 to
93f5484
Compare
|
Very, very nice! |
dscho
approved these changes
Dec 21, 2018
dscho
added a commit
to dscho/git
that referenced
this pull request
Feb 7, 2019
…out-hook Rebase: Run post-checkout hook on checkout
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes a regression introduced by switching to the built-in rebase: the
post-checkouthook was run in the scripted version but not in the built-in version.