Initialize rev before using &rev.pending #2008
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dscho
requested changes
Jan 4, 2019
t/t3903-stash.sh
Outdated
| echo new >file4 && | ||
| git add --intent-to-add file4 && | ||
| test_must_fail git stash && | ||
| git rm -f file4 |
There was a problem hiding this comment.
I think this should be moved up 1 line and should read test_when_finished "git rm -f file4" instead.
If reset_tree returns a non-zero value, stash_working_tree calls object_array_clear with &rev.pending before rev is initialized. This causes a segmentation fault. Prevent this by initializing rev before calling reset_tree. This fixes git-for-windows#2006. Signed-off-by: Matthew Kraai <[email protected]>
dscho
approved these changes
Jan 9, 2019
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If reset_tree returns a non-zero value, stash_working_tree calls
object_array_clear with &rev.pending before rev is initialized. This
causes a segmentation fault. Prevent this by initializing rev before
calling reset_tree.
This fixes #2006.
Signed-off-by: Matthew Kraai [email protected]