Drop deprecated git status --show-ignored-directory option
#2067
Conversation
|
@clboles Could you please make sure that this option is indeed not used any longer in any projects you maintain? |
|
This option is still used by the version of Git that ships with Visual Studio 2017. As VFSForGit overrides the version of Git that Visual Studio uses to the one that VFSForGit installs, this will cause issue with VFSForGit and Visual Studio 2017 installed on the same machine. We could look at moving this patch into only the Git for VFSForGit, as an option. |
True. But VFS for Git has this option deprecated for ages now, too... So all that would be needed is to make sure that Team Explorer does not use the deprecated option, but instead the one sanctioned by the core Git reviewers. @clboles ... this is in your court now... |
|
For lurkers: We will have to wait with merging this PR for a while, until we can be sure that no users of those deprecated options are left. |
It's time, I think. |
dscho
force-pushed
the
drop-deprecated-status-option
branch
from
87b5a52 to
19107ef
Compare
We said we would remove --show-ignored-directory in v2.16.0 or v2.17.0, but v2.36.1 is now the current version and we still have not removed it. Let's do it now. We had to wait for a while because some users were still on Visual Studio 2017 (which used that option until a certain stage). But then, users who upgrade Git will also upgrade Visual Studio, or so one would hope, therefore they should not be affected by this change. Signed-off-by: Johannes Schindelin <[email protected]>
We said we would remove --show-ignored-directory in v2.16.0 or v2.17.0, but v2.36.1 is now the current version and we still have not removed it. Let's do it now. We had to wait for a while because some users were still on Visual Studio 2017 (which used that option until a certain stage). But then, users who upgrade Git will also upgrade Visual Studio, or so one would hope, therefore they should not be affected by this change. Signed-off-by: Johannes Schindelin <[email protected]>
dscho
force-pushed
the
drop-deprecated-status-option
branch
from
19107ef to
18ab665
Compare
The Git for Windows-only `--show-ignored-directory` option of `git status`, which was deprecated a long time ago, [was finally removed](git-for-windows/git#2067). Signed-off-by: Johannes Schindelin <[email protected]>
In the v2.15.x timeframe, that option was integrated into core Git, but with a different syntax:
--ignored=matching. In Git for Windows, since we offered--show-ignored-directoryin at least one official version, we reintroduced it as a backstop, deprecating it and intending to remove it soon.The time has come.